Conversation
We added this field while implementing rolling updates and chose to populate it with semantics similar to the appsv1.Deployment controller which ignores terminating Pods. However, our controller does *not* ignore terminating PostgreSQL Pods because they are still writing to disk and still participating in HA quorum. So, this field now reflects the number of observed Pods, regardless of their state. This is the same approach taken by the appsv1.StatefulSet controller. When this field is zero, we can be relatively certain that all PostgreSQL processes have stopped and disks are idle. Issue: [sc-13696] See: https://issue.k8s.io/107920 See: e0a885c
The tests were written before the status fields existed. This also reduces the scope of variables used only for failure messages.
These tests are flaky in CI and the current failure messages do not show why. Add a testing package that can format, sort, and filter corev1.Events.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying it out.