Save and restore user span context on hibernation.#6516
Open
mar-cf wants to merge 4 commits intomar/worker-context-2from
Open
Save and restore user span context on hibernation.#6516mar-cf wants to merge 4 commits intomar/worker-context-2from
mar-cf wants to merge 4 commits intomar/worker-context-2from
Conversation
Contributor
|
The restore side is safe — when autogate is disabled, This PR is clean. The changes are minimal, well-gated behind an autogate, and the types all align correctly. The test update correctly reflects the new parenting relationship. LGTM |
|
The generated output of |
mar-cf
force-pushed
the
mar/worker-context-2
branch
3 times, most recently
from
a4c6843 to
6d81884
Compare
mar-cf
force-pushed
the
mar/worker-context-hibernation
branch
from
4d60ddf to
dd0f2a5
Compare
mar-cf
commented
Apr 14, 2026
| // Dispatch the event, restoring the trace context captured at acceptWebSocket time. | ||
| SpanParent userSpanParent = SpanParent(nullptr); | ||
| KJ_IF_SOME(ctx, hib.userSpanContext) { | ||
| userSpanParent = SpanParent::fromSpanContext(tracing::SpanContext::clone(ctx)); |
Contributor
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.