Skip to content

Add timeouts to async steps #1833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vkalapov wants to merge 7 commits into from

Merge branch 'master' into add-timeouts-3

5addefb
Select commit
Loading
Failed to load commit list.
Closed

Add timeouts to async steps #1833

Merge branch 'master' into add-timeouts-3
5addefb
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded May 18, 2026 in 1m 6s

Quality Gate passed

Issues
13 New issues
0 Accepted issues

Measures
0 Security Hotspots
83.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 23 in multiapps-controller-process/src/main/java/org/cloudfoundry/multiapps/controller/process/steps/TimeoutAsyncFlowableStep.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=cloudfoundry_multiapps-controller&issues=AZ46DTge3bP5d0I4ajoL&open=AZ46DTge3bP5d0I4ajoL&pullRequest=1833

Check warning on line 33 in multiapps-controller-process/src/test/java/org/cloudfoundry/multiapps/controller/process/util/TimeoutStepStateManagerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this block of code, fill it in, or add a comment explaining why it is empty. 

See more on https://sonarcloud.io/project/issues?id=cloudfoundry_multiapps-controller&issues=AZ46DThX3bP5d0I4ajoO&open=AZ46DThX3bP5d0I4ajoO&pullRequest=1833

Check warning on line 42 in multiapps-controller-process/src/test/java/org/cloudfoundry/multiapps/controller/process/util/TimeoutServiceResourceNameResolverTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this block of code, fill it in, or add a comment explaining why it is empty. 

See more on https://sonarcloud.io/project/issues?id=cloudfoundry_multiapps-controller&issues=AZ46DThf3bP5d0I4ajoQ&open=AZ46DThf3bP5d0I4ajoQ&pullRequest=1833

Check failure on line 96 in multiapps-controller-core/src/main/java/org/cloudfoundry/multiapps/controller/core/cf/v2/ServicesCloudModelBuilder.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "create-service-key-timeout" 3 times. 

See more on https://sonarcloud.io/project/issues?id=cloudfoundry_multiapps-controller&issues=AZ46DTeI3bP5d0I4ajoH&open=AZ46DTeI3bP5d0I4ajoH&pullRequest=1833

Check failure on line 95 in multiapps-controller-core/src/main/java/org/cloudfoundry/multiapps/controller/core/cf/v2/ServicesCloudModelBuilder.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "bind-service-timeout" 3 times. 

See more on https://sonarcloud.io/project/issues?id=cloudfoundry_multiapps-controller&issues=AZ46DTeI3bP5d0I4ajoG&open=AZ46DTeI3bP5d0I4ajoG&pullRequest=1833

Check warning on line 42 in multiapps-controller-process/src/test/java/org/cloudfoundry/multiapps/controller/process/util/TimeoutServiceResourceNameResolverTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "closeable" local variable. 

See more on https://sonarcloud.io/project/issues?id=cloudfoundry_multiapps-controller&issues=AZ46DThf3bP5d0I4ajoP&open=AZ46DThf3bP5d0I4ajoP&pullRequest=1833

Check warning on line 20 in multiapps-controller-process/src/main/java/org/cloudfoundry/multiapps/controller/process/steps/GlobalTimeoutSettingStep.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=cloudfoundry_multiapps-controller&issues=AZ46DTgP3bP5d0I4ajoK&open=AZ46DTgP3bP5d0I4ajoK&pullRequest=1833

Check warning on line 155 in multiapps-controller-process/src/test/java/org/cloudfoundry/multiapps/controller/process/util/TimeoutStepStateManagerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Update this method so that its implementation is not identical to "testGetStepStartTimeReturnsExistingTimeWhenInitialized" on line 106. 

See more on https://sonarcloud.io/project/issues?id=cloudfoundry_multiapps-controller&issues=AZ46DThX3bP5d0I4ajoM&open=AZ46DThX3bP5d0I4ajoM&pullRequest=1833

Check failure on line 70 in multiapps-controller-process/src/test/java/org/cloudfoundry/multiapps/controller/process/util/TimeoutValueResolverTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation. 

See more on https://sonarcloud.io/project/issues?id=cloudfoundry_multiapps-controller&issues=AZ46DThn3bP5d0I4ajoS&open=AZ46DThn3bP5d0I4ajoS&pullRequest=1833

Check failure on line 70 in multiapps-controller-process/src/test/java/org/cloudfoundry/multiapps/controller/process/util/TimeoutValueResolverTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=cloudfoundry_multiapps-controller&issues=AZ46DThm3bP5d0I4ajoR&open=AZ46DThm3bP5d0I4ajoR&pullRequest=1833

Check failure on line 111 in multiapps-controller-process/src/main/java/org/cloudfoundry/multiapps/controller/process/util/TimeoutType.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove usage of generic wildcard type. 

See more on https://sonarcloud.io/project/issues?id=cloudfoundry_multiapps-controller&issues=AZ46DTfc3bP5d0I4ajoJ&open=AZ46DTfc3bP5d0I4ajoJ&pullRequest=1833

Check warning on line 33 in multiapps-controller-process/src/test/java/org/cloudfoundry/multiapps/controller/process/util/TimeoutStepStateManagerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "closeable" local variable. 

See more on https://sonarcloud.io/project/issues?id=cloudfoundry_multiapps-controller&issues=AZ46DThX3bP5d0I4ajoN&open=AZ46DThX3bP5d0I4ajoN&pullRequest=1833

Check failure on line 94 in multiapps-controller-core/src/main/java/org/cloudfoundry/multiapps/controller/core/cf/v2/ServicesCloudModelBuilder.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "create-service-timeout" 3 times. 

See more on https://sonarcloud.io/project/issues?id=cloudfoundry_multiapps-controller&issues=AZ46DTeI3bP5d0I4ajoI&open=AZ46DTeI3bP5d0I4ajoI&pullRequest=1833
View more details on SonarQubeCloud