Skip to content

Async step timeouts #1834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vkalapov wants to merge 7 commits into
base: master
Choose a base branch
from

Fix sonalcloud scan issues

f3efdb1
Select commit
Loading
Failed to load commit list.
Open

Async step timeouts #1834

Fix sonalcloud scan issues
f3efdb1
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded May 18, 2026 in 1m 0s

Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
83.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 20 in multiapps-controller-process/src/main/java/org/cloudfoundry/multiapps/controller/process/steps/GlobalTimeoutSettingStep.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=cloudfoundry_multiapps-controller&issues=AZ46UL7XO8aoxos4O03K&open=AZ46UL7XO8aoxos4O03K&pullRequest=1834

Check warning on line 33 in multiapps-controller-process/src/test/java/org/cloudfoundry/multiapps/controller/process/util/TimeoutStepStateManagerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "closeable" local variable. 

See more on https://sonarcloud.io/project/issues?id=cloudfoundry_multiapps-controller&issues=AZ46UL9AO8aoxos4O03N&open=AZ46UL9AO8aoxos4O03N&pullRequest=1834

Check warning on line 155 in multiapps-controller-process/src/test/java/org/cloudfoundry/multiapps/controller/process/util/TimeoutStepStateManagerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Update this method so that its implementation is not identical to "testGetStepStartTimeReturnsExistingTimeWhenInitialized" on line 106. 

See more on https://sonarcloud.io/project/issues?id=cloudfoundry_multiapps-controller&issues=AZ46UL9AO8aoxos4O03M&open=AZ46UL9AO8aoxos4O03M&pullRequest=1834

Check warning on line 33 in multiapps-controller-process/src/test/java/org/cloudfoundry/multiapps/controller/process/util/TimeoutStepStateManagerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this block of code, fill it in, or add a comment explaining why it is empty. 

See more on https://sonarcloud.io/project/issues?id=cloudfoundry_multiapps-controller&issues=AZ46UL9AO8aoxos4O03O&open=AZ46UL9AO8aoxos4O03O&pullRequest=1834

Check failure on line 111 in multiapps-controller-process/src/main/java/org/cloudfoundry/multiapps/controller/process/util/TimeoutType.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove usage of generic wildcard type. 

See more on https://sonarcloud.io/project/issues?id=cloudfoundry_multiapps-controller&issues=AZ46UL5vO8aoxos4O03J&open=AZ46UL5vO8aoxos4O03J&pullRequest=1834

Check warning on line 23 in multiapps-controller-process/src/main/java/org/cloudfoundry/multiapps/controller/process/steps/TimeoutAsyncFlowableStep.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=cloudfoundry_multiapps-controller&issues=AZ46UL71O8aoxos4O03L&open=AZ46UL71O8aoxos4O03L&pullRequest=1834
View more details on SonarQubeCloud