Skip to content

Use reactphp/async instead of clue/reactphp-block#121

Merged
clue merged 2 commits intoclue:1.xfrom
clue-labs:async
Apr 12, 2026
Merged

Use reactphp/async instead of clue/reactphp-block#121
clue merged 2 commits intoclue:1.xfrom
clue-labs:async

Conversation

@clue
Copy link
Copy Markdown
Owner

@clue clue commented Apr 12, 2026

This changeset updates the test suite to use reactphp/async instead of the deprecated clue/reactphp-block. See https://github.com/reactphp/async.

Builds on top of #120, clue/reactphp-block#67, clue/reactphp-block#68 and clue/reactphp-redis#149
Supersedes / closes #110 and #111 (Thank you @dinooo13 for the initial work on this!)

@clue clue added this to the v1.5.0 milestone Apr 12, 2026
@clue clue requested a review from Copilot April 12, 2026 17:41
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the test suite to replace deprecated clue/reactphp-block usage with reactphp/async, and adds additional socket cleanup to avoid leaving server sockets open during/after tests.

Changes:

  • Replace Block\await() + Loop::get() with \React\Async\await() in functional test helpers.
  • Track and close the primary SocketServer after each test, and close additional per-test sockets where applicable.
  • Update composer.json dev dependencies to drop clue/block-react and add react/async.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
tests/FunctionalTest.php Migrates blocking awaits to react/async and adds explicit socket shutdowns to prevent lingering listeners.
composer.json Swaps dev dependency from clue/block-react to react/async.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@clue clue merged commit d895448 into clue:1.x Apr 12, 2026
18 checks passed
@clue clue deleted the async branch April 12, 2026 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants