Switch GithubAppInstallationController away from ja_resource and canary (#1055)

Helps support #864

Closes #890

Author: treble37

lib/code_corps/policy/github_app_installation.ex

@@ -6,9 +6,6 @@ defmodule CodeCorps.Policy.GithubAppInstallation do
 
   alias CodeCorps.{GithubAppInstallation, User}
 
-  def create?(%User{} = user, %Ecto.Changeset{} = changeset),
-    do: changeset |> get_project |> owned_by?(user)
+  def create?(%User{} = user, params), do: params |> get_project |> owned_by?(user)
 
-  def update?(%User{} = user, %GithubAppInstallation{} = github_app_installation),
-    do: github_app_installation |> get_project |> owned_by?(user)
 end

lib/code_corps/policy/policy.ex

@@ -86,7 +86,7 @@ defmodule CodeCorps.Policy do
     do: Policy.StripePlatformCustomer.create?(current_user, params)
   defp can?(%User{} = current_user, :show, %StripePlatformCustomer{} = stripe_platform_customer, %{}),
     do: Policy.StripePlatformCustomer.show?(current_user, stripe_platform_customer)
-
+  defp can?(%User{} = user, :create, %GithubAppInstallation{}, %{} = params), do: Policy.GithubAppInstallation.create?(user, params)
 
   defimpl Canada.Can, for: User do
     # NOTE: Canary sets an :unauthorized and a :not_found handler on a config level
@@ -104,7 +104,6 @@ defmodule CodeCorps.Policy do
     def can?(%User{} = user, :update, %DonationGoal{} = comment), do: Policy.DonationGoal.update?(user, comment)
     def can?(%User{} = user, :delete, %DonationGoal{} = comment), do: Policy.DonationGoal.delete?(user, comment)
 
-    def can?(%User{} = user, :create, %Changeset{data: %GithubAppInstallation{}} = changeset), do: Policy.GithubAppInstallation.create?(user, changeset)
 
     def can?(%User{} = user, :create, Role), do: Policy.Role.create?(user)
   end

lib/code_corps_web/controllers/github_app_installation_controller.ex

@@ -1,29 +1,34 @@
 defmodule CodeCorpsWeb.GithubAppInstallationController do
   use CodeCorpsWeb, :controller
-  use JaResource
 
   import CodeCorps.Helpers.Query, only: [id_filter: 2]
 
-  alias CodeCorps.{GithubAppInstallation}
+  alias CodeCorps.{GithubAppInstallation, User}
 
-  @preloads [:project, :user]
+  action_fallback CodeCorpsWeb.FallbackController
+  plug CodeCorpsWeb.Plug.DataToAttributes
+  plug CodeCorpsWeb.Plug.IdsToIntegers
 
-  plug :load_resource, model: GithubAppInstallation, only: [:show], preload: @preloads
-  plug :load_and_authorize_changeset, model: GithubAppInstallation, only: [:create], preload: @preloads
-
-  plug JaResource
-
-  @spec model :: module
-  def model, do: CodeCorps.GithubAppInstallation
+  @spec index(Conn.t, map) :: Conn.t
+  def index(%Conn{} = conn, %{} = params) do
+    with installations <- GithubAppInstallation |> id_filter(params) |> Repo.all do
+      conn |> render("index.json-api", data: installations)
+    end
+  end
 
-  @spec filter(Plug.Conn.t, Ecto.Query.t, String.t, String.t) :: Ecto.Query.t
-  def filter(_conn, query, "id", id_list) do
-    query |> id_filter(id_list)
+  @spec show(Conn.t, map) :: Conn.t
+  def show(%Conn{} = conn, %{"id" => id}) do
+    with %GithubAppInstallation{} = installation <- GithubAppInstallation |> Repo.get(id) do
+      conn |> render("show.json-api", data: installation)
+    end
   end
 
-  @spec handle_create(Plug.Conn.t, map) :: Ecto.Changeset.t
-  def handle_create(_conn, attributes) do
-    %GithubAppInstallation{}
-    |> GithubAppInstallation.create_changeset(attributes)
+  @spec create(Plug.Conn.t, map) :: Conn.t
+  def create(%Conn{} = conn, %{} = params) do
+    with %User{} = current_user <- conn |> Guardian.Plug.current_resource,
+         {:ok, :authorized} <- current_user |> Policy.authorize(:create, %GithubAppInstallation{}, params),
+         {:ok, %GithubAppInstallation{} = installation} <- %GithubAppInstallation{} |> GithubAppInstallation.create_changeset(params) |> Repo.insert do
+      conn |> put_status(:created) |> render("show.json-api", data: installation)
+    end
   end
 end

test/lib/code_corps/policy/github_app_installation_test.exs

@@ -1,7 +1,7 @@
 defmodule CodeCorps.Policy.GithubAppInstallationTest do
   use CodeCorps.PolicyCase
 
-  import CodeCorps.Policy.GithubAppInstallation, only: [create?: 2, update?: 2]
+  import CodeCorps.Policy.GithubAppInstallation, only: [create?: 2]
   import CodeCorps.GithubAppInstallation, only: [create_changeset: 2]
 
   alias CodeCorps.GithubAppInstallation
@@ -24,23 +24,4 @@ defmodule CodeCorps.Policy.GithubAppInstallationTest do
       refute create?(user, changeset)
     end
   end
-
-  describe "update?/2" do
-    test "returns true when user is owner of the project" do
-      project = insert(:project)
-      user = insert(:user)
-      insert(:project_user, project: project, user: user, role: "owner")
-      github_app_installation = insert(:github_app_installation, project: project, user: user)
-
-      assert update?(user, github_app_installation)
-    end
-
-    test "returns false for normal user" do
-      project = insert(:project)
-      user = insert(:user)
-      github_app_installation = insert(:github_app_installation, project: project, user: user)
-
-      refute update?(user, github_app_installation)
-    end
-  end
 end