[pull] master from cube-js:master#467
Merged
Merged
Conversation
β¦anning (#10874) In `get_vanilla_row`, the "deprecated time dimensions without granularity" pass used to rebuild a per-row `HashMap<&str, (level, value)>` to pick the lowest-level granularity column per base dimension, then re-emit each winner under the bare `{cube}.{dim}` key. The winner is fully determined by the plan (granularity levels are static per column), so the selection is moved into `build_vanilla_plan` once, and `get_vanilla_row` just copies the already-transformed value out of the row IndexMap. Benchmarks (`bench_transform_time_scenarios`, vanilla, c16 Γ r100k, vs master): | scenario | mean | change vs master | 95% CI | |--------------------------------|---------:|-----------------:|-------------------| | one_time_dim_day | 154.3 ms | β4.40% | [β6.89%, β1.85%] | | one_time_dim_custom_granularity| 143.8 ms | β10.70% | [β12.34%, β8.82%]| | two_time_dims | 198.7 ms | β10.11% | [β11.49%, β8.78%]| | no_time_dim (fast path) | 84.9 ms | +3.58% | within noise |
Signed-off-by: Alex Qyoun-ae <4062971+MazterQyou@users.noreply.github.com>
| scenario | master | new | Ξ | |------------------------------------------------|-----------|-----------|--------| | vanilla/c64_r10000 | (master) | 14.9 ms | β52.9% | | vanilla/c64_r50000 | 154.2 ms | 76.7 ms | β50.3% | | vanilla/c64_r100000 | 312.8 ms | 164.2 ms | β47.5% | | scenarios/no_time_dim/c16_r100000 | 86.2 ms | 58.5 ms | β32.1% | | scenarios/one_time_dim_day/c16_r100000 | 157.1 ms | 142.3 ms | β9.4% | | scenarios/one_time_dim_custom_gran/c16_r100000 | 163.6 ms | 133.1 ms | β18.6% | | scenarios/two_time_dims/c16_r100000 | 217.9 ms | 190.6 ms | β12.5% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? π Please sponsor : )