Skip to content

[pull] main from facebook:main #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 2 commits into from
Oct 10, 2025
Merged

[pull] main from facebook:main #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b33dc1
fix(theme): remove "Edit this page" button from print view (#11463)
richk21 Oct 10, 2025
43665c5
docs: remove Astro link in v3.9 blog post (nodejs upgrade) (#11469)
slorber Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/docusaurus-theme-classic/src/theme/EditMetaRow/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@ export default function EditMetaRow({
}: Props): ReactNode {
return (
<div className={clsx('row', className)}>
<div className="col">{editUrl && <EditThisPage editUrl={editUrl} />}</div>
<div className={clsx('col', styles.noPrint)}>
{editUrl && <EditThisPage editUrl={editUrl} />}
</div>
<div className={clsx('col', styles.lastUpdated)}>
{(lastUpdatedAt || lastUpdatedBy) && (
<LastUpdated
Expand Down
6 changes: 6 additions & 0 deletions packages/docusaurus-theme-classic/src/theme/EditMetaRow/styles.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,9 @@
text-align: right;
}
}

@media print {
.noPrint {
display: none;
}
}
2 changes: 1 addition & 1 deletion website/blog/releases/3.9/index.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import BrowserWindow from '@site/src/components/BrowserWindow';

In [#11408](https://github.com/facebook/docusaurus/pull/11408), we have dropped support for Node.js 18, and the new minimum required Node.js version is now v20.0.

Although it may look like a runtime requirement breaking change, Node.js 18 reached [End-of-Life](https://nodejs.org/en/about/releases/). It [won't receive security updates](https://nodejs.org/en/blog/announcements/node-18-eol-support), and you shouldn't use it anymore. Dropping End-of-Life versions of Node.js on minor version releases is a common practice in the Node.js ecosystem (see for examples [Astro 5.8](https://astro.build/blog/astro-580/)), that we now officially endorse and document on our [release process](/community/release-process#nodejs-support).
Although it may look like a runtime requirement breaking change, Node.js 18 reached [End-of-Life](https://nodejs.org/en/about/releases/). It [won't receive security updates](https://nodejs.org/en/blog/announcements/node-18-eol-support), and you shouldn't use it anymore. Dropping End-of-Life versions of Node.js on minor version releases is a common practice in the Node.js ecosystem, that we now officially endorse and document on our [release process](/community/release-process#nodejs-support).

This upgrade is further motivated by our dependencies:

Expand Down
Loading