[pull] main from remotion-dev:main#845
Merged
Merged
Conversation
`preservesPitch?: boolean` is now a per-component prop on OffthreadVideo, Html5Video (Video), and Html5Audio (Audio), threading through to the matching `HTMLMediaElement.preservesPitch` setter via the same effect that syncs `playbackRate`. Default behavior is unchanged: when the prop is omitted, the browser default applies and nothing is written. The earlier approach (a Player-level prop wired through PlaybackRateContext and the global useMediaPlayback consumer) is dropped per maintainer feedback. Player, Thumbnail, TimelineContext, and the player-level validator are back to their pre-PR state. validate-media-props gains a boolean validator that matches the existing peer-validator message format. Tests cover default, true, false, and invalid input on each of the three component validators plus the runtime sync to HTMLMediaElement.preservesPitch. Docs: removed the entry from packages/docs/docs/player/api.mdx and added matching entries to html5-audio.mdx, html5-video.mdx, and offthreadvideo.mdx. Fixes #7070
…w-only @JonnyBurger asked to expose preservePitch on Audio/Video/OffthreadVideo, matching his preferred spelling. The PR already touched the media components (no Player wiring), so the change is a rename to preservePitch plus: - Default preservePitch=true (matches HTMLMediaElement.preservesPitch default) - Render path no longer assigns preservesPitch on the DOM element; toneFrequency remains the render-time pitch control - Docs note that preservePitch only affects preview playback; render uses toneFrequency Tests updated to use the new prop name and the true default. Verification gap: sandbox could not run pnpm install (registry unreachable); upstream CI will catch any regression.
Add preservePitch to fallbackHtml5AudioProps and document it alongside fallbackOffthreadVideoProps. Co-authored-by: Cursor <cursoragent@cursor.com>
…Rendering Match VideoForRendering: strip preview-only preservePitch before spreading props onto Img. Co-authored-by: Cursor <cursoragent@cursor.com>
`remotion`: support `preservesPitch` prop
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )