Conversation
Two-part fix for the user-reported "translate fails after language change" bug. The chrome.storage.sync token store was empty for anonymous users (loginAsAnonymous never persisted), and loginWithLastSession treated a valid anon session as "login failed" because updateIsLogin returns false unless user.type === "user". Every fresh popup open therefore broadcast StoreUserTokenMessage(null) and 412'd the next translate from any tab. Also guard onDocClick against non-Element event targets, which surfaced as "target.closest is not a function" in the same Wikipedia console run. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
🎉 This PR is included in version 1.11.0-dev.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.11.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🏷️ PR Title:
fix: persist anonymous tokens and stop logout cascade on anon sessions
📋 Summary
This PR addresses the issue of anonymous tokens not being persisted properly and prevents the logout cascade from triggering during anonymous user sessions.
🔗 Related Tasks
#825db93 - Persist anonymous tokens and stop logout cascade on anonymous sessions
📝 Additional Details
The fix ensures that anonymous sessions maintain their tokens securely and that the logout process does not inadvertently log out other sessions or users when dealing with anonymous users.
📜 Commit List
825db93 fix: persist anonymous tokens and stop logout-cascade on anon sessions