Skip to content

Add button to retrieve more/all rows, and refresh result#516

Merged
SanjulaGanepola merged 5 commits intomainfrom
feature/retrieve-more-rows
Apr 19, 2026
Merged

Add button to retrieve more/all rows, and refresh result#516
SanjulaGanepola merged 5 commits intomainfrom
feature/retrieve-more-rows

Conversation

@SanjulaGanepola
Copy link
Copy Markdown
Member

@SanjulaGanepola SanjulaGanepola commented Apr 11, 2026

Changes

As of right now, users have to scroll to the bottom of the results panel to load more results. Several users have reported that this has been an issue. Although I haven't found an exact fix to the scrolling issue, I was able to reproduce the issue on my end by zooming in (quite a lot!). As a work around and nice feature, I thought it would make sense to add a button to Retrieve More Rows. The button should only be enabled when there are more rows to fetch.

Fixes #509
Fixes #470
Fixes #341
Fixes #287

image

How To Test

  1. Run a query with more than 100 rows and verify the new button works in fetching more rows.
  2. Run a query with less than 100 rows (or repeat step 1 until all rows are retrieved) and verify the new button is disabled.
  3. Run a query, use the Clear Results (button beside it) and verify the new button is disabled.

Signed-off-by: Sanjula Ganepola <Sanjula.Ganepola@ibm.com>
@SanjulaGanepola SanjulaGanepola requested review from a team and forstie April 11, 2026 02:04
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 11, 2026

👋 A new build is available for this PR based on 813e15e.

@SanjulaGanepola SanjulaGanepola marked this pull request as draft April 11, 2026 02:22
@Apsoftbe
Copy link
Copy Markdown

@SanjulaGanepola
Hello,
Tested with file that had 999 records.
At EOF button "Retrieve more rows" is disabled.
Clicking on "Clear Results" button "Retrieve more rows" is disabled too.
Thanks
Peter

@forstie
Copy link
Copy Markdown
Collaborator

forstie commented Apr 18, 2026

Instead of "More" rows, why not have the control retrieve "All" rows... like ACS's RSS.

@Apsoftbe
Copy link
Copy Markdown

Maybe it can be interesting to have a parameter
To define "Number of rows" to retrieve at a time

@forstie
Copy link
Copy Markdown
Collaborator

forstie commented Apr 18, 2026

Right, similar to ACS

image

and

image

Signed-off-by: Sanjula Ganepola <Sanjula.Ganepola@ibm.com>
Signed-off-by: Sanjula Ganepola <Sanjula.Ganepola@ibm.com>
Signed-off-by: Sanjula Ganepola <Sanjula.Ganepola@ibm.com>
@SanjulaGanepola SanjulaGanepola changed the title Add button to retrieve more rows Add button to retrieve more/all rows, and refresh result Apr 18, 2026
@SanjulaGanepola
Copy link
Copy Markdown
Member Author

@Apsoftbe @forstie Thanks for the input! I went ahead and implemented those suggestions. This is ready for review/testing.

Added a Retrieve... submenu with 2 options:

image

You can also configure the number of rows to fetch in the settings:

image

I also added a Refresh button:

image

@SanjulaGanepola SanjulaGanepola marked this pull request as ready for review April 18, 2026 20:21
@forstie
Copy link
Copy Markdown
Collaborator

forstie commented Apr 19, 2026

This PR is on fire!

Everything worked well for me.
I did wonder if we should put guardrails on the settings to protect the user from themselves...?

image image

Otherwise, ship it and way2go!

Copy link
Copy Markdown
Collaborator

@forstie forstie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fire

Signed-off-by: Sanjula Ganepola <Sanjula.Ganepola@ibm.com>
@SanjulaGanepola
Copy link
Copy Markdown
Member Author

Good catch on adding the guardrail, forgot about that. Got that in!

image

@SanjulaGanepola SanjulaGanepola merged commit b9e1972 into main Apr 19, 2026
1 check passed
@SanjulaGanepola SanjulaGanepola deleted the feature/retrieve-more-rows branch April 23, 2026 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SQL result limit 100 - no page down load more than 100 rows Enhancement Request: Retrieve all rows button/option Refresh button on result sets

3 participants