Fixed CL Notebook output for Code for IBM i v3#530
Open
sebjulliand wants to merge 1 commit intomainfrom
Open
Conversation
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
|
👋 A new build is available for this PR based on ec8ca36. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code for IBM i v3 uses Mapepire to run CL commands and an additionnal property must be used when invoking
runCommand: thegetSpooledFilesmust betrueto retrieve the actual output of the command (that goes into a spooled file now).The change is compatible with version 2 of Code for i - the PR is meant to fix this issue for those using the pre-release version of Code for i.
It also fixes a few TypeScript issues in the Notebooks classes.