Changed tmp folder to be user's tmp folder. Also updated vsce to use latest version#3183
Open
julesyan wants to merge 1 commit intocodefori:masterfrom
Open
Changed tmp folder to be user's tmp folder. Also updated vsce to use latest version#3183julesyan wants to merge 1 commit intocodefori:masterfrom
julesyan wants to merge 1 commit intocodefori:masterfrom
Conversation
…latest version Signed-off-by: Julia Yan <julia.yan@ibm.com>
julesyan
temporarily deployed
to
testing_environment
GitHub Actions
Inactive
sebjulliand
requested changes
May 7, 2026
Member
sebjulliand
left a comment
sebjulliand
left a comment
There was a problem hiding this comment.
It looks good!
I'd require two small things:
- Can you add a few test cases to test and cover use cases of
Tools.ensureFullPath? - Since /tmp will automatically be changed to
.vscode/tmpunconditionally, it would be nice to show a notification to warn the user about the change that happened in their config and/or document the fact that/tmpwill not be permitted
Thanks! 🙏🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
How to test this PR
Checklist