Conversation
closed COD-193
closed COD-283
|
|
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the project to Tailwind 4 while making related fixes and consolidations across both the web and CMS apps. Key changes include updating PostCSS configurations, refactoring component class names and layout structures, and adding a new migration (COD-296) to adjust form block width handling.
Reviewed Changes
Copilot reviewed 53 out of 59 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| apps/web/postcss.config.mjs | Added a new ESM configuration using '@tailwindcss/postcss' for Tailwind 4. |
| apps/web/postcss.config.cjs | Removed the legacy CommonJS configuration. |
| apps/web/app/routes/_index.tsx & $slug.tsx | Reordered Tailwind class names for improved consistency. |
| apps/web/app/root.tsx | Adjusted element ordering and updated the icon component usage. |
| apps/web/app/components/desktop-navigation.tsx & container.tsx | Updated import paths and class ordering. |
| apps/cms/tailwind.config.mjs | Removed CMS-specific Tailwind config. |
| apps/cms/src/migrations/* | Added migration COD-296 to convert enum width columns and update defaults. |
| apps/cms/src/components/Logo.client.tsx | Revised the Logo component by removing explicit width and height. |
| apps/cms/src/app/(frontend)/layout.tsx | Refactored layout structure with updated Tailwind classes. |
| apps/cms/postcss.config.mjs | Switched CMS PostCSS config to use '@tailwindcss/postcss' instead of autoprefixer. |
Files not reviewed (6)
- .prettierrc: Language not supported
- apps/cms/src/app/(frontend)/globals.css: Language not supported
- apps/cms/src/app/(payload)/custom.scss: Language not supported
- apps/cms/src/migrations/20241218_093558_cod_213.json: Language not supported
- apps/web/app/tailwind.css: Language not supported
- apps/web/package.json: Language not supported
Comments suppressed due to low confidence (3)
apps/cms/src/components/Logo.client.tsx:4
- [nitpick] The explicit width and height properties for CdwrCloud have been removed. If fixed sizing is required for layout consistency, consider reintroducing explicit dimensions via props or Tailwind classes.
<CdwrCloud width="100" height="100" className="text-black dark:text-white opacity-80" />
apps/cms/postcss.config.mjs:4
- The autoprefixer plugin configuration has been removed. If autoprefixing is still needed for browser compatibility, consider adding autoprefixer back into the plugins configuration.
'@tailwindcss/postcss': {}
apps/web/app/components/desktop-navigation.tsx:1
- [nitpick] The import path for the 'cn' function has been updated. Please confirm that the new path is correct and consistent across the codebase.
import { cn } from '@codeware/shared/util/ui';
|
View your CI Pipeline Execution ↗ for commit 8bc16a7.
☁️ Nx Cloud last updated this comment at |
closed COD-296
|
✨ Your pull request projects are ready for preview
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #294 +/- ##
=======================================
Coverage 81.09% 81.09%
=======================================
Files 63 63
Lines 1074 1074
Branches 216 216
=======================================
Hits 871 871
Misses 203 203 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
✨ Your pull request projects are ready for preview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed COD-193, COD-283, COD-296