Conversation
closed COD-306
closed COD-307
closed COD-302,COD-304
closed COD-300
|
|
There was a problem hiding this comment.
Pull Request Overview
This PR integrates a new navigation collection and site settings functionality while updating several UI components and database migrations to leverage a unified navigation tree. Key changes include:
- Replacing the legacy pages filtering with a navigationTree API in navigation components.
- Integrating new collections (navigation and site-settings) and their corresponding migrations.
- Updating admin groups and utility imports across various collections and components.
Reviewed Changes
Copilot reviewed 43 out of 43 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| apps/web/app/components/render-pages-doc.tsx | New component to render pages documents based on navigation doc. |
| apps/web/app/components/mobile-navigation.tsx | Updated to use navigationTree instead of pages filtering. |
| apps/web/app/components/footer.tsx | Refactored to use navigationTree and conditional rendering when empty. |
| apps/web/app/components/desktop-navigation.tsx | Replaced pages filtering with navigationTree usage. |
| apps/cms/src/payload.config.ts | Fixed typo in getPlugins and added navigation/site-settings collections. |
| apps/cms/src/migrations/* | Added new migration for navigation and site-settings with updated constraints and indices. |
| apps/cms/src/components/ArrayRowLabel | Introduced custom array row label types for tenants and navigation. |
| apps/cms/src/collections/* | Updated admin groups and fixed component references for row labels. |
| apps/cms/src/app/(payload)/admin/importMap.js | Updated import mappings for the new row label components. |
Comments suppressed due to low confidence (1)
apps/cms/src/components/NavigationArrayRowLabel.tsx:10
- React components should not be declared as async because they need to return React elements synchronously. Consider removing the async keyword and refactoring any asynchronous operations to use appropriate React hooks.
export const NavigationArrayRowLabel: React.FC<ArrayRowLabel> = async (props) => {
|
View your CI Pipeline Execution ↗ for commit 29932dd.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #296 +/- ##
=======================================
Coverage 81.09% 81.09%
=======================================
Files 63 63
Lines 1074 1074
Branches 216 216
=======================================
Hits 871 871
Misses 203 203 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
✨ Your pull request projects are ready for preview
|
closed COD-308
|
✨ Your pull request projects are ready for preview
|
closed COD-308
|
✨ Your pull request projects are ready for preview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes COD-300, COD-301, COD-302, COD-304, COD-306, COD-307, COD-308