feat(cms): update to payload 3.34 and enable turbopack in dev#304
feat(cms): update to payload 3.34 and enable turbopack in dev#304
Conversation
|
|
There was a problem hiding this comment.
Copilot reviewed 9 out of 11 changed files in this pull request and generated no comments.
Files not reviewed (2)
- apps/cms/project.json: Language not supported
- package.json: Language not supported
Comments suppressed due to low confidence (3)
libs/shared/util/payload-types/src/lib/payload-types.ts:575
- [nitpick] The newly introduced radio block interface mirrors other block types; consider aligning the property ordering with existing patterns to ensure consistency across form field definitions.
| {
libs/app-cms/util/plugins/src/lib/plugins/forms/customized-fields.ts:46
- [nitpick] Confirm that excluding 'radio' fields from placeholder checks is intentional; if radio fields might ever need a placeholder, additional handling could be required.
if (['checkbox', 'radio'].includes(fieldName) === false) {
apps/cms/src/migrations/20250414_134656_cod_318.ts:70
- Ensure that dropping the 'placeholder' column from 'forms_blocks_select_locales' aligns with the overall schema changes and that any necessary data migration has been addressed.
ALTER TABLE "forms_blocks_select_locales" DROP COLUMN IF EXISTS "placeholder";
|
View your CI Pipeline Execution ↗ for commit 95c2b10.
☁️ Nx Cloud last updated this comment at |
|
✨ Your pull request projects are ready for preview
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #304 +/- ##
============================================
- Coverage 100.00% 81.08% -18.92%
============================================
Files 5 63 +58
Lines 26 1073 +1047
Branches 5 216 +211
============================================
+ Hits 26 870 +844
- Misses 0 203 +203 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
closed COD-318