Skip to content

feat(cms): update to payload 3.34 and enable turbopack in dev#304

Merged
hakalb merged 1 commit intomainfrom
cod-318-payload-turbo
Apr 14, 2025
Merged

feat(cms): update to payload 3.34 and enable turbopack in dev#304
hakalb merged 1 commit intomainfrom
cod-318-payload-turbo

Conversation

@hakalb
Copy link
Copy Markdown
Member

@hakalb hakalb commented Apr 14, 2025

closed COD-318

@hakalb hakalb self-assigned this Apr 14, 2025
Copilot AI review requested due to automatic review settings April 14, 2025 13:51
@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 9 out of 11 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • apps/cms/project.json: Language not supported
  • package.json: Language not supported
Comments suppressed due to low confidence (3)

libs/shared/util/payload-types/src/lib/payload-types.ts:575

  • [nitpick] The newly introduced radio block interface mirrors other block types; consider aligning the property ordering with existing patterns to ensure consistency across form field definitions.
          | {

libs/app-cms/util/plugins/src/lib/plugins/forms/customized-fields.ts:46

  • [nitpick] Confirm that excluding 'radio' fields from placeholder checks is intentional; if radio fields might ever need a placeholder, additional handling could be required.
if (['checkbox', 'radio'].includes(fieldName) === false) {

apps/cms/src/migrations/20250414_134656_cod_318.ts:70

  • Ensure that dropping the 'placeholder' column from 'forms_blocks_select_locales' aligns with the overall schema changes and that any necessary data migration has been addressed.
ALTER TABLE "forms_blocks_select_locales" DROP COLUMN IF EXISTS "placeholder";

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Apr 14, 2025

View your CI Pipeline Execution ↗ for commit 95c2b10.

Command Status Duration Result
nx-cloud record -- nx format:check ✅ Succeeded 11s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-14 13:53:46 UTC

@codeware-actions
Copy link
Copy Markdown

✨ Your pull request projects are ready for preview

Project App name Preview
cms cdwr-cms-pr-304 https://cdwr-cms-pr-304.fly.dev
web cdwr-web-pr-304 https://cdwr-web-pr-304.fly.dev

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.08%. Comparing base (3f1526f) to head (95c2b10).
Report is 1 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (3f1526f) and HEAD (95c2b10). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (3f1526f) HEAD (95c2b10)
2 1
Additional details and impacted files
@@             Coverage Diff              @@
##              main     #304       +/-   ##
============================================
- Coverage   100.00%   81.08%   -18.92%     
============================================
  Files            5       63       +58     
  Lines           26     1073     +1047     
  Branches         5      216      +211     
============================================
+ Hits            26      870      +844     
- Misses           0      203      +203     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hakalb hakalb enabled auto-merge April 14, 2025 14:08
@hakalb hakalb added this pull request to the merge queue Apr 14, 2025
Merged via the queue into main with commit 3bb3b3f Apr 14, 2025
17 checks passed
@hakalb hakalb deleted the cod-318-payload-turbo branch April 14, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants