Conversation
|
|
There was a problem hiding this comment.
Pull Request Overview
This PR implements a new Social Media Block while deprecating the legacy card group field and associated components. Key changes include the removal of the card group field/code, the addition of social media block components and row labels, and updates to payload configurations, migrations, and collection settings to incorporate the new block.
Reviewed Changes
Copilot reviewed 57 out of 57 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| libs/app-cms/ui/fields/* | Removal of the legacy card group field and its row label component |
| libs/app-cms/ui/blocks/social-media/* | Addition of the Social Media Block and its custom row label component |
| libs/app-cms/ui/blocks/card/* | Updates to the Card Block to use inline field definitions and updated RowLabel component |
| apps/* | Updates in payload config, migrations, collections, and import maps to include the new social media block and adjust for removed card-group code |
Comments suppressed due to low confidence (3)
libs/app-cms/ui/blocks/card/card.block.ts:31
- [nitpick] The field name was renamed from 'customCards' to 'cards' to improve clarity; please confirm that this naming aligns with the overall conventions used across blocks.
name: 'cards',
apps/cms/src/collections/reusable-content/reusable-content.collection.ts:62
- [nitpick] Consider adding tests to verify that getActiveKeys returns the correct block references for the layout builder to ensure new block integrations work as expected.
blockReferences: getActiveKeys<BlockSlug>(blocks),
apps/cms/src/migrations/20250416_221010_cod_322.ts:11
- [nitpick] The migration aggressively drops and renames legacy card tables; please double-check that these schema changes match the intended deprecation strategy and avoid conflicts with remaining references.
DROP TABLE "cards" CASCADE;
|
View your CI Pipeline Execution ↗ for commit bfe1b39.
☁️ Nx Cloud last updated this comment at |
|
✨ Your pull request project is ready for preview
|
|
✨ Your pull request project is ready for preview
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #307 +/- ##
============================================
- Coverage 100.00% 81.08% -18.92%
============================================
Files 5 63 +58
Lines 26 1073 +1047
Branches 5 216 +211
============================================
+ Hits 26 870 +844
- Misses 0 203 +203 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
✨ Your pull request projects are ready for preview
|
|
✨ Your pull request projects are ready for preview
|
closed COD-320
|
✨ Your pull request projects are ready for preview
|
closed cod-320, cod-322