Skip to content

feat(cms): implement file area block and seed a dedicated page#316

Merged
hakalb merged 1 commit intomainfrom
cod-292-filearea
Dec 2, 2025
Merged

feat(cms): implement file area block and seed a dedicated page#316
hakalb merged 1 commit intomainfrom
cod-292-filearea

Conversation

@hakalb
Copy link
Copy Markdown
Member

@hakalb hakalb commented May 16, 2025

closed COD-292

@hakalb hakalb self-assigned this May 16, 2025
Copilot AI review requested due to automatic review settings May 16, 2025 10:55
@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements functionality to support a dedicated file area block and seeds a dedicated page for tenants with the file-area tag. It updates several seed functions and collection configurations, adds new migrations for tag and file-area support, and adjusts the reset-db process to integrate media deletion.

Reviewed Changes

Copilot reviewed 99 out of 99 changed files in this pull request and generated no comments.

Show a summary per file
File Description
libs/app-cms/feature/seed/src/lib/local-api/ensure-post.ts Updated return type to remove string values, ensuring consistent numeric IDs.
libs/app-cms/feature/seed/src/lib/local-api/ensure-page.ts Adjusted return type to match numeric ID pattern.
libs/app-cms/feature/seed/src/lib/local-api/ensure-navigation.ts Modified navigation seeding logic to merge missing items and return an object with navigation ID and new items.
libs/app-cms/feature/seed/src/lib/local-api/ensure-media.ts Added file existence check and improved media lookup.
libs/app-cms/feature/seed/src/lib/custom-seed.ts Added custom seed logic for file-area pages and navigation.
apps/cms/src/utils/reset-db.ts Updated reset workflow to handle media deletion and use Drizzle adapter for DB drop.
apps/cms/src/payload.config.ts Expanded block registrations to include file-area and image blocks.
apps/cms/src/migrations/* Introduced new migration for COD-292 with new tables, constraints, and indices.
apps/cms/src/collections/* Modified collections (tags, posts, pages, media, categories, reusable-content) to support new file-area functionality and adjust admin columns.
apps/cms/.env.local Updated Ethereal email credentials for local development.
Comments suppressed due to low confidence (5)

libs/app-cms/feature/seed/src/lib/local-api/ensure-post.ts:23

  • The removal of the string type from the return type may affect clients expecting string IDs; please verify that all consuming code has been updated accordingly.
): Promise<Post | number> {

libs/app-cms/feature/seed/src/lib/local-api/ensure-page.ts:24

  • Ensure that changing the return type to only allow numeric IDs does not break any existing integrations or tests that relied on a string type being returned.
): Promise<Page | number> {

libs/app-cms/feature/seed/src/lib/local-api/ensure-category.ts:19

  • Confirm that the removal of string from the return type is intentional and that all corresponding usages in the codebase are adjusted to expect a numeric ID.
): Promise<Category | number> {

apps/cms/src/collections/posts/posts.collection.ts:45

  • [nitpick] The removal of the 'tenant' column from the defaultColumns array may impact admin displays; please confirm that this adjustment aligns with the intended admin UI design.
defaultColumns: ['title', 'updatedAt'],

apps/cms/src/collections/categories/categories.collection.ts:17

  • [nitpick] Removing the 'tenant' column from the defaultColumns array should be verified to ensure the admin interface still provides all necessary context for category records.
defaultColumns: ['name', 'slug'],

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented May 16, 2025

View your CI Pipeline Execution ↗ for commit efe4d5f

Command Status Duration Result
nx e2e nx-payload-e2e -c skip-docker ✅ Succeeded 19m 15s View ↗
nx e2e nx-payload-e2e -c quick ✅ Succeeded 17m 40s View ↗

☁️ Nx Cloud last updated this comment at 2025-12-02 21:36:51 UTC

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented May 16, 2025

View your CI Pipeline Execution ↗ for commit fa75240.

Command Status Duration Result
nx-cloud record -- nx format:check ❌ Failed 12s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-16 10:57:26 UTC

1 similar comment
@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented May 16, 2025

View your CI Pipeline Execution ↗ for commit fa75240.

Command Status Duration Result
nx-cloud record -- nx format:check ❌ Failed 12s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-16 10:57:26 UTC

@codeware-actions
Copy link
Copy Markdown

✨ Your pull request projects are ready for preview

Project App name Preview
cms cdwr-cms-pr-316 https://cdwr-cms-pr-316.fly.dev
web cdwr-web-pr-316 https://cdwr-web-pr-316.fly.dev

@codecov
Copy link
Copy Markdown

codecov Bot commented May 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.26%. Comparing base (68c1639) to head (efe4d5f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #316   +/-   ##
=======================================
  Coverage   75.26%   75.26%           
=======================================
  Files          61       61           
  Lines        1047     1047           
  Branches      224      224           
=======================================
  Hits          788      788           
  Misses        259      259           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codeware-actions
Copy link
Copy Markdown

✨ Your pull request projects are ready for preview

Project App name Preview
cms cdwr-cms-pr-316 https://cdwr-cms-pr-316.fly.dev
web cdwr-web-pr-316 https://cdwr-web-pr-316.fly.dev

@codeware-actions
Copy link
Copy Markdown

✨ Your pull request projects are ready for preview

Project App name Preview
cms cdwr-cms-pr-316 https://cdwr-cms-pr-316.fly.dev
web cdwr-web-pr-316 https://cdwr-web-pr-316.fly.dev

@codeware-actions
Copy link
Copy Markdown

✨ Your pull request projects are ready for preview

Project App name Preview
cms cdwr-cms-pr-316 https://cdwr-cms-pr-316.fly.dev
web cdwr-web-pr-316 https://cdwr-web-pr-316.fly.dev

@codeware-actions
Copy link
Copy Markdown

✨ Your pull request projects are ready for preview

Project App name Preview
cms cdwr-cms-pr-316 https://cdwr-cms-pr-316.fly.dev
web cdwr-web-pr-316 https://cdwr-web-pr-316.fly.dev

@codeware-actions
Copy link
Copy Markdown

✨ Your pull request projects are ready for preview

Project App name Preview
cms cdwr-cms-pr-316 https://cdwr-cms-pr-316.fly.dev
web cdwr-web-pr-316 https://cdwr-web-pr-316.fly.dev

@codeware-actions
Copy link
Copy Markdown

✨ Your pull request projects are ready for preview

Project App name Preview
cms cdwr-cms-pr-316 https://cdwr-cms-pr-316.fly.dev
web cdwr-web-pr-316 https://cdwr-web-pr-316.fly.dev

@hakalb hakalb force-pushed the cod-292-filearea branch 2 times, most recently from 17a9108 to 611a916 Compare November 14, 2025 07:40
@codeware-actions
Copy link
Copy Markdown

✨ Your pull request project is ready for preview

Project App name Preview
web cdwr-web-pr-316 https://cdwr-web-pr-316.fly.dev

@codeware-actions
Copy link
Copy Markdown

✨ Your pull request project is ready for preview

Project App name Preview
web cdwr-web-pr-316 https://cdwr-web-pr-316.fly.dev

@codeware-actions
Copy link
Copy Markdown

✨ Your pull request project is ready for preview

Project App name Preview
web cdwr-web-pr-316 https://cdwr-web-pr-316.fly.dev

@codeware-actions
Copy link
Copy Markdown

✨ Your pull request project is ready for preview

Project App name Preview
web cdwr-web-pr-316 https://cdwr-web-pr-316.fly.dev

@codeware-actions
Copy link
Copy Markdown

✨ Your pull request project is ready for preview

Project App name Preview
web cdwr-web-pr-316 https://cdwr-web-pr-316.fly.dev

@codeware-actions
Copy link
Copy Markdown

✨ Your pull request project is ready for preview

Project App name Preview
web cdwr-web-pr-316 https://cdwr-web-pr-316.fly.dev

@codeware-actions
Copy link
Copy Markdown

✨ Your pull request project is ready for preview

Project App name Preview
web cdwr-web-pr-316 https://cdwr-web-pr-316.fly.dev

@codeware-actions
Copy link
Copy Markdown

✨ Your pull request projects are ready for preview

Project App name Preview
cms cdwr-cms-pr-316 https://cdwr-cms-pr-316.fly.dev
web cdwr-web-pr-316 https://cdwr-web-pr-316.fly.dev

@codeware-actions
Copy link
Copy Markdown

✨ Your pull request projects are ready for preview

Project App name Preview
cms cdwr-cms-pr-316 https://cdwr-cms-pr-316.fly.dev
web cdwr-web-pr-316 https://cdwr-web-pr-316.fly.dev

@hakalb hakalb added this pull request to the merge queue Dec 2, 2025
Merged via the queue into main with commit 828db6e Dec 2, 2025
18 checks passed
@hakalb hakalb deleted the cod-292-filearea branch December 2, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants