feat: make name optional on BlueprintEntityType for extend path#1198
Merged
Conversation
When an entity_types[] entry has prefix but no name, it extends an existing entity type (e.g., org) with storage instead of creating a new one. This makes name optional — only prefix is required. Companion to constructive-db#1250.
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes
nameoptional onBlueprintEntityType. When anentity_types[]entry hasprefixbut noname, it extends an existing entity type (e.g., the built-in org) with storage instead of creating a new entity type.Changes:
generate-types.ts:requiredProp('name')→optionalProp('name'), updated JSDocblueprint-types.generated.ts:name: string→name?: string, updated interface/field docsCompanion to constructive-db#1250.
Review & Testing Checklist for Human
name+prefix) still type-checks correctlynameoptionality + JSDoc)Notes
Low risk — types-only change. The SQL implementation (constructive-db#1250) is already merged.
Link to Devin session: https://app.devin.ai/sessions/c0494871633d4beb91f1e16e53c776d1
Requested by: @pyramation