feat(codegen): re-export FetchAdapter from ORM barrel#1203
Merged
Conversation
Add FetchAdapter to the barrel re-export from ./client so it is importable via @scope/sdk/orm without needing a separate /client subpath import.
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Split from #1200 (Issue 2 only).
Adds
FetchAdapterto the barrel re-export from./clientin the generatedindex.ts, so it's importable via@scope/sdk/ormwithout needing a separate/clientsubpath.Context:
FetchAdapteris the defaultGraphQLAdapterimplementation that wrapscreateFetch()from@constructive-io/fetch. It's already present in every generatedclient.ts. This change only affects the barrel export — making it accessible from the top-level ORM import.Note from investigation: This may not be necessary — end users don't typically construct
FetchAdapterdirectly. TheOrmClientConfigalready exposesendpoint,fetch, andadapteroptions that handle all use cases (including test mocking). Consider whether this export surface is actually needed.Files changed:
graphql/codegen/src/core/codegen/orm/client-generator.ts— addedFetchAdapterto barrel export ASTgraphql/codegen/src/__tests__/codegen/__snapshots__/client-generator.test.ts.snap— updated 2 snapshotsReview & Testing Checklist for Human
FetchAdaptershould be part of the public SDK API surface, or if it should remain an internal implementation detailcd graphql/codegen && pnpm testto confirm all tests passNotes
This is Issue 2 from the original PR #1200. Issue 1 (BulkUploadFileInput types) is in a separate PR. Dan flagged that this export may be unnecessary since
@constructive-io/fetchalready exists andFetchAdapteris an internal default.Link to Devin session: https://app.devin.ai/sessions/11c358ec8678488eba3255c53f3e440f
Requested by: @pyramation