Switch package manager from npm to yarn#288
Open
Carifio24 wants to merge 5 commits intocosmicds:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All of our other projects are using yarn as their package manager, so for the sake of consistency, this PR switches this project to use yarn (as opposed to npm). The process here is pretty straightforward:
package-lock.jsonwithyarn.lockThis PR also moves our type- and testing-related dependencies into the package's dev dependencies. With the old EBS build process we needed these in the regular dependencies, but that's not the case anymore.
Note that this PR doesn't touch the Terraform infrastructure - since the AWS deployment is now based on the Dockerfile, we only need to update things there.