Add missing _is_private() check to get_private_key_pkcs8_string()#183
Draft
toddr-bot wants to merge 1 commit into
Draft
Add missing _is_private() check to get_private_key_pkcs8_string()#183toddr-bot wants to merge 1 commit into
toddr-bot wants to merge 1 commit into
Conversation
Every private-key operation validates _is_private() before proceeding: get_private_key_string, decrypt, private_encrypt, check_key, sign. The PKCS#8 export variant was the sole exception — calling it on a public-only key produced silent garbage (pre-3.x) or a cryptic OpenSSL error (3.x) instead of a clear croak. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_is_private()guard toget_private_key_pkcs8_string(), matching every other private-key operationWhy
Every private-key operation in RSA.xs validates
_is_private()beforeproceeding:
get_private_key_string,decrypt,private_encrypt,check_key,sign. The PKCS#8 export variant was missed — calling iton a public-only key produced silent garbage on pre-3.x or a cryptic
OpenSSL error on 3.x instead of a clear croak.
Same class of bug as PR #143 which fixed the identical gap in
get_private_key_string().Testing
t/format.tverifies the croak message🤖 Generated with Claude Code