Skip to content

Fix three compiler warnings in RSA.xs #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
toddr-bot wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −6
Draft

Fix three compiler warnings in RSA.xs #185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions RSA.xs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,12 +367,11 @@ SV* extractBioString(BIO* p_stringBio)
SV* sv;
char* datap;
long datasize;
int error = 0;

THROW(BIO_flush(p_stringBio) == 1);
if (BIO_flush(p_stringBio) != 1) goto err;

datasize = BIO_get_mem_data(p_stringBio, &datap);
THROW(datasize > 0);
if (datasize <= 0) goto err;

sv = newSVpv(datap, datasize);

Expand Down Expand Up @@ -526,12 +525,12 @@ SV* rsa_crypt(rsaData* p_rsa, SV* p_from,
CHECK_NEW(to, size, UNSIGNED_CHAR);
to_length = p_crypt(
from_length, from, (unsigned char*) to, p_rsa->rsa, p_rsa->padding);
#endif
if (to_length < 0)
{
Safefree(to);
CHECK_OPEN_SSL(0);
}
#endif
sv = newSVpv((char* ) to, to_length);
Safefree(to);
return sv;
Expand Down Expand Up @@ -1505,9 +1504,12 @@ PPCODE:
STRLEN sig_length;

sig = (unsigned char*) SvPV(sig_SV, sig_length);
if (EVP_PKEY_get_size(p_rsa->rsa) < sig_length)
{
croak("Signature longer than key");
int key_size = EVP_PKEY_get_size(p_rsa->rsa);
if (key_size < 0 || (STRLEN)key_size < sig_length)
{
croak("Signature longer than key");
}
}

unsigned char digest_buf[EVP_MAX_MD_SIZE];
Expand Down
Loading