Conversation
abentkamp
commented
May 6, 2026
|
|
||
| macro_rules! step_identical_methods { | ||
| ($Name:ty) => { | ||
| fn forward(start: Self, n: usize) -> Self { |
Collaborator
Author
There was a problem hiding this comment.
These functions should panic with with overflow, but with my implementaiton they panic duew to unwrap. In production builds, they should not panic at all, actually, but my implementation does.
abentkamp
commented
May 6, 2026
| use crate::option::Option; | ||
| use crate::result::Result; | ||
| /// See [`std::iter::Step`] | ||
| pub trait Step: Clone + PartialOrd<Self> + Sized { |
Collaborator
Author
There was a problem hiding this comment.
PartialOrd and Sized refer to core, here. I think that's correct?
Collaborator
There was a problem hiding this comment.
It depends, if we really need it that can be fine but ideally we would refer to the traits from core_models, otherwise we might end up having an incorrect order of items in the produced Lean
abentkamp
commented
May 6, 2026
maximebuyse
reviewed
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds:
try/try_fromimplsiter.range.Stepand its impls for integersunchecked_Xandchecked_X_unsignedarithmetic functionsThe Step impls are modeled after the official Rust implementation. In hindsight, maybe converting to mathematical integers and back would have been simpler?