Fix lab 10 segmentation fault in tasks#181
Open
robertmercea wants to merge 2 commits into
Open
Conversation
Fix running the program resulting in segmentation fault by changing the offset from which the string length is read Signed-off-by: robertmercea <robertmercea@gmail.com>
Fix running the program resulting in segmentation fault by changing the offset from which the string length is read Signed-off-by: robertmercea <robertmercea@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisite Checklist
Description of changes
Previously, running the executables for the
read-stdin-getsandread-stdin-fgetstasks would result in theprint_byteloop running indefinitely, resulting in a segmentation fault. This happened because the limit for the iterator was read from the wrong address (or due to stack alignments made by the user).The fix I provided changes the address from which the limit is read, such that the program no longer crashes.