Start to build using Makefiles#1336
Open
danrmiller wants to merge 117 commits into
Open
Conversation
…r icons Co-authored-by: sneurlax <sneurlax@gmail.com>
Co-authored-by: sneurlax <sneurlax@gmail.com>
Co-authored-by: sneurlax <sneurlax@gmail.com>
…stack.stackduo (fixes invalid bundle-id chars)
…de*.app and switches xcode-select to it, so the CI runner uses the full Xcode SDK instead of CLI tools.
…ow-sdk-path actually resolves
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## staging #1336 +/- ##
========================================
Coverage 4.93% 4.93%
========================================
Files 1064 1064
Lines 107980 107980
========================================
Hits 5328 5328
Misses 102652 102652 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
danrmiller
commented
May 13, 2026
Collaborator
Author
danrmiller
left a comment
danrmiller
left a comment
There was a problem hiding this comment.
Will discuss on call with @parasew
| "\"${DT_TOOLCHAIN_DIR}/usr/lib/swift/${PLATFORM_NAME}\"", | ||
| /usr/lib/swift, | ||
| ); | ||
| PRODUCT_MODULE_NAME = stack_wallet; |
Collaborator
Author
There was a problem hiding this comment.
Per @julian-CStack since its a template, stack_wallet should not be found in this file. If thats an updated requirement for newer macos or general macos builds we'll need to update the template to actual gen scripts to update it on copy
| export NEW_APP_ID="com.cypherstack.stackduo" | ||
| export NEW_APP_ID_CAMEL="com.cypherstack.stackDuo" | ||
| export NEW_APP_ID_SNAKE="com.cypherstack.stack_duo" | ||
| export NEW_APP_ID_SNAKE="com.cypherstack.stackduo" |
Collaborator
Author
There was a problem hiding this comment.
@julian-CStack is unsure about the purpose of this change as the bash var is specifically called snake case id.
…job to Makefile make build-macos now drives the full macOS release build via the Makefile, replacing the old build_app.sh -d -s download path with source compilation. build.yaml: remove redundant Configure/GetDeps/GitVersions/Build steps now handled by make build-macos. Add dtolnay/rust-toolchain@stable + 1.85.1 install so check-reqs passes. Makefile: test-mwc now ensures local stable rustup toolchain is installed and defaulted before flutter test -d macos, fixing missing flutter_libsparkmobile framework linker error when Cargokit rebuilds for Debug mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Courtesy of ongoing work by @parasew this introduces Nix flake + Makefile towards eventual reproducible builds.