Skip to content

Overhaul#4

Merged
gwaybio merged 1 commit into
cytomining:mainfrom
gwaybio:main
May 15, 2026
Merged

Overhaul#4
gwaybio merged 1 commit into
cytomining:mainfrom
gwaybio:main

Conversation

@gwaybio
Copy link
Copy Markdown
Member

@gwaybio gwaybio commented May 15, 2026

co-made with claude

Dave, I might recommend only skimming this - and then, filing smaller PRs to correct anything. I believe dev will go faster this way

@gwaybio gwaybio requested a review from d33bs May 15, 2026 16:56
@gwaybio
Copy link
Copy Markdown
Member Author

gwaybio commented May 15, 2026

looking at the precommit failures... I need to clean some stuff up! Probably still good to skim

Copy link
Copy Markdown
Member

@d33bs d33bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hugo has ways to test the build. Just double checking: can you run locally and does all look well?

Comment thread public/favicon-32x32.png
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to update these so they reflect the cytomining brand. These are the images that appear with tabs in the browser. I suggest using ImageMagick to do this.

Comment thread public/history/index.xml
<rss version="2.0" xmlns:atom="http://www.w3.org/2005/Atom">
<channel>
<title>History on Cytomining</title>
<link>http://localhost:1314/history/</link>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might not work correctly when published, unsure exactly. Localhost is usually an indication of "local to this machine".

Copy link
Copy Markdown
Member

@d33bs d33bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be good to disable the htmllint and also move to dependabot based pre-commit hook updates.

@gwaybio
Copy link
Copy Markdown
Member Author

gwaybio commented May 15, 2026

Hugo has ways to test the build. Just double checking: can you run locally and does all look well?

Yes, it looks great

@gwaybio
Copy link
Copy Markdown
Member Author

gwaybio commented May 15, 2026

Going to merge, and let's iteratively fix! (including the items you mention)

@gwaybio gwaybio merged commit 99269a1 into cytomining:main May 15, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants