Skip to content

Fix #14546 FN uninitMemberVar (in-class initializers but no constructor) #8274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrchr-github wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Fix #14546 FN uninitMemberVar (in-class initializers but no constructor) #8274

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f04a62d
Update checkclass.h
chrchr-github Feb 27, 2026
d0c2336
Update checkclass.cpp
chrchr-github Feb 27, 2026
ed7a13a
Update testconstructors.cpp
chrchr-github Feb 27, 2026
fef16fb
Update testconstructors.cpp
chrchr-github Feb 27, 2026
fb6ba0f
Format
web-flow Feb 27, 2026
39973d1
Initialize members
web-flow Feb 27, 2026
6381e50
Merge branch 'danmar:main' into chr_14546
chrchr-github Mar 30, 2026
162cc68
Use count()
chrchr-github Apr 10, 2026
990f673
Merge branch 'danmar:main' into chr_14546
chrchr-github Apr 10, 2026
c8e0baf
Update checkclass.cpp
chrchr-github Apr 10, 2026
0e7eb75
Dedicated ID, release notes
web-flow Apr 10, 2026
8e2ff1b
Format
web-flow Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
197 changes: 123 additions & 74 deletions lib/checkclass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,90 @@ CheckClass::CheckClass(const Tokenizer *tokenizer, const Settings *settings, Err
mSymbolDatabase(tokenizer?tokenizer->getSymbolDatabase():nullptr)
{}

bool CheckClass::isInitialized(const CheckClass::Usage& usage, FunctionType funcType) const
{
const Variable& var = *usage.var;

if (usage.assign || usage.init || var.isStatic())
return true;

if (!var.nameToken() || var.nameToken()->isAnonymous())
return true;

if (var.valueType() && var.valueType()->pointer == 0 && var.type() && var.type()->needInitialization == Type::NeedInitialization::False && var.type()->derivedFrom.empty())
return true;

if (var.isConst() && funcType == FunctionType::eOperatorEqual) // We can't set const members in assignment operator
return true;

// Check if this is a class constructor
if (!var.isPointer() && !var.isPointerArray() && var.isClass() && funcType == FunctionType::eConstructor) {
// Unknown type so assume it is initialized
if (!var.type()) {
if (var.isStlType() && var.valueType() && var.valueType()->containerTypeToken) {
if (var.valueType()->type == ValueType::Type::ITERATOR)
{
// needs initialization
}
else if (var.getTypeName() == "std::array") {
const Token* ctt = var.valueType()->containerTypeToken;
if (!ctt->isStandardType() &&
(!ctt->type() || ctt->type()->needInitialization != Type::NeedInitialization::True) &&
!mSettings->library.podtype(ctt->str())) // TODO: handle complex type expression
return true;
}
else
return true;
}
else
return true;
}

// Known type that doesn't need initialization or
// known type that has member variables of an unknown type
else if (var.type()->needInitialization != Type::NeedInitialization::True)
return true;
}

// Check if type can't be copied
if (!var.isPointer() && !var.isPointerArray() && var.typeScope()) {
if (funcType == FunctionType::eMoveConstructor) {
if (canNotMove(var.typeScope()))
return true;
}
else {
if (canNotCopy(var.typeScope()))
return true;
}
}
return false;
}

void CheckClass::handleUnionMembers(std::vector<Usage>& usageList)
{
// Assign 1 union member => assign all union members
for (const Usage& usage : usageList) {
const Variable& var = *usage.var;
if (!usage.assign && !usage.init)
continue;
const Scope* varScope1 = var.nameToken()->scope();
while (varScope1->type == ScopeType::eStruct)
varScope1 = varScope1->nestedIn;
if (varScope1->type == ScopeType::eUnion) {
for (Usage& usage2 : usageList) {
const Variable& var2 = *usage2.var;
if (usage2.assign || usage2.init || var2.isStatic())
continue;
const Scope* varScope2 = var2.nameToken()->scope();
while (varScope2->type == ScopeType::eStruct)
varScope2 = varScope2->nestedIn;
if (varScope1 == varScope2)
usage2.assign = true;
}
}
}
}

//---------------------------------------------------------------------------
// ClassCheck: Check that all class constructors are ok.
//---------------------------------------------------------------------------
Expand Down Expand Up @@ -145,6 +229,7 @@ void CheckClass::constructors()
});

// There are no constructors.
std::set<const Variable*> diagVars;
if (scope->numConstructors == 0 && printStyle && !usedInUnion) {
// If there is a private variable, there should be a constructor..
int needInit = 0, haveInit = 0;
Expand All @@ -163,8 +248,10 @@ void CheckClass::constructors()
if (haveInit == 0)
noConstructorError(scope->classDef, scope->className, scope->classDef->str() == "struct");
else
for (const Variable* uv : uninitVars)
for (const Variable* uv : uninitVars) {
uninitVarError(uv->typeStartToken(), uv->scope()->className, uv->name());
diagVars.emplace(uv);
}
}
}

Expand Down Expand Up @@ -201,85 +288,15 @@ void CheckClass::constructors()
std::list<const Function *> callstack;
initializeVarList(func, callstack, scope, usageList);

// Assign 1 union member => assign all union members
for (const Usage &usage : usageList) {
const Variable& var = *usage.var;
if (!usage.assign && !usage.init)
continue;
const Scope* varScope1 = var.nameToken()->scope();
while (varScope1->type == ScopeType::eStruct)
varScope1 = varScope1->nestedIn;
if (varScope1->type == ScopeType::eUnion) {
for (Usage &usage2 : usageList) {
const Variable& var2 = *usage2.var;
if (usage2.assign || usage2.init || var2.isStatic())
continue;
const Scope* varScope2 = var2.nameToken()->scope();
while (varScope2->type == ScopeType::eStruct)
varScope2 = varScope2->nestedIn;
if (varScope1 == varScope2)
usage2.assign = true;
}
}
}
handleUnionMembers(usageList);

// Check if any variables are uninitialized
for (const Usage &usage : usageList) {
const Variable& var = *usage.var;

if (usage.assign || usage.init || var.isStatic())
continue;

if (!var.nameToken() || var.nameToken()->isAnonymous())
continue;

if (var.valueType() && var.valueType()->pointer == 0 && var.type() && var.type()->needInitialization == Type::NeedInitialization::False && var.type()->derivedFrom.empty())
if (isInitialized(usage, func.type))
continue;

if (var.isConst() && func.isOperator()) // We can't set const members in assignment operator
continue;

// Check if this is a class constructor
if (!var.isPointer() && !var.isPointerArray() && var.isClass() && func.type == FunctionType::eConstructor) {
// Unknown type so assume it is initialized
if (!var.type()) {
if (var.isStlType() && var.valueType() && var.valueType()->containerTypeToken) {
if (var.valueType()->type == ValueType::Type::ITERATOR)
{
// needs initialization
}
else if (var.getTypeName() == "std::array") {
const Token* ctt = var.valueType()->containerTypeToken;
if (!ctt->isStandardType() &&
(!ctt->type() || ctt->type()->needInitialization != Type::NeedInitialization::True) &&
!mSettings->library.podtype(ctt->str())) // TODO: handle complex type expression
continue;
}
else
continue;
}
else
continue;
}

// Known type that doesn't need initialization or
// known type that has member variables of an unknown type
else if (var.type()->needInitialization != Type::NeedInitialization::True)
continue;
}

// Check if type can't be copied
if (!var.isPointer() && !var.isPointerArray() && var.typeScope()) {
if (func.type == FunctionType::eMoveConstructor) {
if (canNotMove(var.typeScope()))
continue;
} else {
if (canNotCopy(var.typeScope()))
continue;
}
}

// Is there missing member copy in copy/move constructor or assignment operator?
const Variable& var = *usage.var;
bool missingCopy = false;

// Don't warn about unknown types in copy constructors since we
Expand Down Expand Up @@ -326,6 +343,38 @@ void CheckClass::constructors()
}
}
}

if (scope->numConstructors == 0) {

// Mark all variables not used
clearAllVar(usageList);

// Variables with default initializers
bool hasAnyDefaultInit = false;
for (Usage& usage : usageList) {
const Variable& var = *usage.var;

// check for C++11 initializer
if (var.hasDefault()) {
usage.init = true;
hasAnyDefaultInit = true;
}
}
if (!hasAnyDefaultInit)
continue;

handleUnionMembers(usageList);

// Check if any variables are uninitialized
for (const Usage& usage : usageList) {
if (isInitialized(usage, FunctionType::eConstructor))
continue;

const Variable& var = *usage.var;
if (diagVars.find(&var) == diagVars.end())
Comment thread
chrchr-github marked this conversation as resolved.
Outdated
uninitVarError(scope->bodyStart, false, FunctionType::eConstructor, var.scope()->className, var.name(), false, false);
}
}
}
}

Expand Down
4 changes: 4 additions & 0 deletions lib/checkclass.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,10 @@ class CPPCHECKLIB CheckClass : public Check {
bool init{};
};

static void handleUnionMembers(std::vector<Usage>& usageList);

bool isInitialized(const Usage& usage, FunctionType funcType) const;

static bool isBaseClassMutableMemberFunc(const Token *tok, const Scope *scope);

/**
Expand Down
4 changes: 2 additions & 2 deletions lib/pathmatch.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,9 +274,9 @@ class PathMatch::PathIterator {
/* Position struct */
struct Pos {
/* String pointer */
const char *p;
const char *p{};
/* Raw characters left */
std::size_t l;
std::size_t l{};
/* Buffered character */
int c {EOF};
};
Expand Down
8 changes: 4 additions & 4 deletions lib/tokenize.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -694,12 +694,12 @@ class CPPCHECKLIB Tokenizer {
struct TypedefInfo {
std::string name;
std::string filename;
int lineNumber;
int column;
int lineNumber{};
Copy link
Copy Markdown
Owner

@danmar danmar Apr 10, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm.. this struct is only accessible in Tokenizer methods and if I look manually I can quite easily see that lineNumber is always initialized when this struct is created.

A user can see this as noise. We could be less pedantic here.

If you feel this is wanted even though we can see the code is safe, well I wonder if a tweaked ID can be used for this more noisy warning.

int column{};
int tagLine{-1};
int tagColumn{-1};
bool used;
bool isFunctionPointer;
bool used{};
bool isFunctionPointer{};
std::vector<TypedefToken> typedefInfoTokens;
};
std::vector<TypedefInfo> mTypedefInfo;
Expand Down
13 changes: 13 additions & 0 deletions test/testconstructors.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ class TestConstructors : public TestFixture {
TEST_CASE(noConstructor13); // #9998
TEST_CASE(noConstructor14); // #10770
TEST_CASE(noConstructor15); // #5499
TEST_CASE(noConstructor16);

TEST_CASE(forwardDeclaration); // ticket #4290/#3190

Expand Down Expand Up @@ -758,6 +759,18 @@ class TestConstructors : public TestFixture {
ASSERT_EQUALS("[test.cpp:3:5]: (warning) Member variable 'C::i2' is not initialized in the constructor. [uninitMemberVar]\n", errout_str());
}

void noConstructor16() {
check("struct S {\n" // #14546
" int a = 0, b;\n"
"};\n");
ASSERT_EQUALS("[test.cpp:1:10]: (warning) Member variable 'S::b' is not initialized in the constructor. [uninitMemberVar]\n", errout_str());
Comment thread
danmar marked this conversation as resolved.
Outdated

check("struct S {\n"
" int a, b;\n"
"};\n");
ASSERT_EQUALS("", errout_str());
}

// ticket #4290 "False Positive: style (noConstructor): The class 'foo' does not have a constructor."
// ticket #3190 "SymbolDatabase: Parse of sub class constructor fails"
void forwardDeclaration() {
Expand Down
Loading