cleanup/server authhelper#13
Merged
Merged
Conversation
Curio's POST /pdp/piece/pull is the FWSS-mediated SP-submits flow: client posts EIP-712-signed extraData and HTTPS source URLs, Curio fetches the pieces, validates extraData via eth_call against PDPVerifier.addPieces(), and submits the on-chain tx. Idempotent on (service, sha256(extraData), dataSetId, recordKeeper). Used by singularity to push pieces to SPs without holding the SP's wallet key. Adds: - Server.PullPieces and Server.WaitForPullPieces in pdp/server.go - PullStatus, PullPieceInput, PullPieceStatus, PullPiecesRequest, PullPiecesResponse, PullPiecesOptions in pdp/types.go - EncodeCreateDataSetAndAddPiecesExtraData in pdp/abi.go for the abi.encode(bytes,bytes) wrapper used when DataSetID is 0 (atomic create-and-add path)
abi.go and server.go had pre-existing whitespace drift (extra blank lines between top-level decls, misaligned var-block alignment). CI's golangci-lint v2 default doesn't run gofmt so master accumulated the drift, but cleaning it up keeps editors+pre-commit hooks happy.
The authHelper field on Server has never been read by any method -- it was apparently reserved for an HTTP-level JWT auth path that never materialized. Curio's FWSS-mediated endpoints authenticate via the EIP-712 signature inside extraData (verified server-side via eth_call), not via Authorization headers. Default Curio deployments run NullAuth. Drops the field from Server, the param from NewServer, the param from Client.NewPDPServer, and the unused local in Client.Storage. Adds a doc comment on Server explaining the actual auth model. Tests adjusted.
After dropping authHelper from setupMockServer, testAuthHelper had no remaining callers, tripping staticcheck U1000. Remove it. Also runs gofmt -w on the files this PR touches (drift was pre-existing on master; CI's golangci-lint v2 default does not run gofmt, but it's still worth keeping clean).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removes unused auth helper, may hold this back if jwt auth is roadmapped for near future