abix: add UnpackSingleTuple, migrate payments.go callers#18
Merged
Conversation
…S1016) CI flagged the literal-style copy at GetRailsForPayerAndToken's results loop. getRailsForPayerAndTokenItem and RailInfoResult have identical field names + types; struct tags don't affect Go's struct conversion identity, so a direct conversion suffices.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracts the
unpackSingleTuplehelper from spregistry intopkg/abix/UnpackSingleTupleand migrates the twocontracts/payments.gosites (GetRail,GetRailsForPayerAndToken) that were using the same fragile inline anon-struct cast. Adds synthetic-payload tests to lock in the unpack path.constants/resolve.goandinternal/generate/addresses.gokeepUnpackIntoInterface-- single primitive output, not affected by the bug -- with a one-line safety comment.Test plan
go build ./...go vet ./...go test ./...