-
Notifications
You must be signed in to change notification settings - Fork 48
Statement level query tag in NodeJS connector #339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jiabin-hu
wants to merge
2
commits into
databricks:main
Choose a base branch
from
jiabin-hu:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| /** | ||
| * Serializes a query tags dictionary into a string for use in confOverlay. | ||
| * | ||
| * Format: comma-separated key:value pairs, e.g. "key1:value1,key2:value2" | ||
| * - If a value is null or undefined, the key is included without a colon or value | ||
| * - Backslashes in keys are escaped; other special characters in keys are not escaped | ||
| * - Special characters (backslash, colon, comma) in values are backslash-escaped | ||
| * | ||
| * @param queryTags - dictionary of query tag key-value pairs | ||
| * @returns serialized string, or undefined if input is empty/null/undefined | ||
| */ | ||
| export function serializeQueryTags( | ||
| queryTags: Record<string, string | null | undefined> | null | undefined, | ||
| ): string | undefined { | ||
| if (queryTags == null) { | ||
| return undefined; | ||
| } | ||
|
|
||
| const keys = Object.keys(queryTags); | ||
| if (keys.length === 0) { | ||
| return undefined; | ||
| } | ||
|
|
||
| return keys | ||
| .map((key) => { | ||
| const escapedKey = key.replace(/\\/g, '\\\\'); | ||
| const value = queryTags[key]; | ||
| if (value == null) { | ||
| return escapedKey; | ||
| } | ||
| const escapedValue = value.replace(/[\\:,]/g, (c) => `\\${c}`); | ||
| return `${escapedKey}:${escapedValue}`; | ||
| }) | ||
| .join(','); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| import { expect } from 'chai'; | ||
| import { serializeQueryTags } from '../../../lib/utils/queryTags'; | ||
|
|
||
| describe('serializeQueryTags', () => { | ||
| it('should return undefined for null input', () => { | ||
| expect(serializeQueryTags(null)).to.be.undefined; | ||
| }); | ||
|
|
||
| it('should return undefined for undefined input', () => { | ||
| expect(serializeQueryTags(undefined)).to.be.undefined; | ||
| }); | ||
|
|
||
| it('should return undefined for empty object', () => { | ||
| expect(serializeQueryTags({})).to.be.undefined; | ||
| }); | ||
|
|
||
| it('should serialize a single tag', () => { | ||
| expect(serializeQueryTags({ team: 'engineering' })).to.equal('team:engineering'); | ||
| }); | ||
|
|
||
| it('should serialize multiple tags', () => { | ||
| const result = serializeQueryTags({ team: 'engineering', app: 'etl' }); | ||
| expect(result).to.equal('team:engineering,app:etl'); | ||
| }); | ||
|
|
||
| it('should omit colon for null value', () => { | ||
| expect(serializeQueryTags({ team: null })).to.equal('team'); | ||
| }); | ||
|
|
||
| it('should omit colon for undefined value', () => { | ||
| expect(serializeQueryTags({ team: undefined })).to.equal('team'); | ||
| }); | ||
|
|
||
| it('should mix null and non-null values', () => { | ||
| const result = serializeQueryTags({ team: 'eng', flag: null, app: 'etl' }); | ||
| expect(result).to.equal('team:eng,flag,app:etl'); | ||
| }); | ||
|
|
||
| it('should escape backslash in value', () => { | ||
| expect(serializeQueryTags({ path: 'a\\b' })).to.equal('path:a\\\\b'); | ||
| }); | ||
|
|
||
| it('should escape colon in value', () => { | ||
| expect(serializeQueryTags({ url: 'http://host' })).to.equal('url:http\\://host'); | ||
| }); | ||
|
|
||
| it('should escape comma in value', () => { | ||
| expect(serializeQueryTags({ list: 'a,b' })).to.equal('list:a\\,b'); | ||
| }); | ||
|
|
||
| it('should escape multiple special characters in value', () => { | ||
| expect(serializeQueryTags({ val: 'a\\b:c,d' })).to.equal('val:a\\\\b\\:c\\,d'); | ||
| }); | ||
|
|
||
| it('should escape backslash in key', () => { | ||
| expect(serializeQueryTags({ 'a\\b': 'value' })).to.equal('a\\\\b:value'); | ||
| }); | ||
|
|
||
| it('should escape backslash in key with null value', () => { | ||
| expect(serializeQueryTags({ 'a\\b': null })).to.equal('a\\\\b'); | ||
| }); | ||
|
|
||
| it('should not escape other special characters in keys', () => { | ||
| expect(serializeQueryTags({ 'key:name': 'value' })).to.equal('key:name:value'); | ||
| }); | ||
| }); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we be doing escaping on the client/driver end ? I remember in SEA escaping happens on the server end. Although currently we only support thrift in node driver, lets confirm if server needs escaping in input.