Skip to content

Add tencentcloud_search tool#400

Open
jayeeliu wants to merge 3 commits intodataelement:mainfrom
jayeeliu:main
Open

Add tencentcloud_search tool#400
jayeeliu wants to merge 3 commits intodataelement:mainfrom
jayeeliu:main

Conversation

@jayeeliu
Copy link
Copy Markdown

@jayeeliu jayeeliu commented Apr 13, 2026

Summary

Search tool using Tencent Cloud Web Search API (WSA) for users in China.

Checklist

  • [✔] Tested locally
  • [✔] No unrelated changes included

@jayeeliu jayeeliu changed the title Add tencentcloud_search tool Add tencentcloud_search tool and fixes database migration failures Apr 14, 2026
@wisdomqin
Copy link
Copy Markdown
Contributor

Thanks for the PR. Please split this into separate PRs:

  1. One PR for the Tencent Cloud Search tool.
  2. One PR for the Alembic migration fixes, with the exact migration failure scenario included.

The migration changes need extra care. In particular, the change to add_participants.py appears to join identities, but that table is created later in the migration chain, so this may break fresh installs.

For the search tool: the direction is fine, but please keep it as a standalone tool. Our search tools are no longer merged into the old web_search engine selector; each provider should be exposed as its own dedicated tool. So the web_search Tencent Cloud branch should be removed unless the full legacy config path is intentionally supported.

Thanks again.

@jayeeliu jayeeliu changed the title Add tencentcloud_search tool and fixes database migration failures Add tencentcloud_search tool Apr 14, 2026
@jayeeliu
Copy link
Copy Markdown
Author

Thanks for the PR. Please split this into separate PRs:

  1. One PR for the Tencent Cloud Search tool.
  2. One PR for the Alembic migration fixes, with the exact migration failure scenario included.

The migration changes need extra care. In particular, the change to add_participants.py appears to join identities, but that table is created later in the migration chain, so this may break fresh installs.

For the search tool: the direction is fine, but please keep it as a standalone tool. Our search tools are no longer merged into the old web_search engine selector; each provider should be exposed as its own dedicated tool. So the web_search Tencent Cloud branch should be removed unless the full legacy config path is intentionally supported.

Thanks again.

This PR for Tencent Cloud Search tool. I've removed tencentcloud search from web_search.

I encountered alembic update error when upgrading Clawith from 1.8.2 to 1.8.3-beta.2.
When executing docker exec clawith-backend-1 alembic upgrade heads, I faced roughly 4 errors. I fixed each by following the error message until the upgrade succeeded.
I’m still getting familiar with Clawith and my time is tight recently. I’ll submit search tool PR first and handle the other one later.

Thank you for providing such a useful tool !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants