You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for the PR. Please split this into separate PRs:
One PR for the Tencent Cloud Search tool.
One PR for the Alembic migration fixes, with the exact migration failure scenario included.
The migration changes need extra care. In particular, the change to add_participants.py appears to join identities, but that table is created later in the migration chain, so this may break fresh installs.
For the search tool: the direction is fine, but please keep it as a standalone tool. Our search tools are no longer merged into the old web_search engine selector; each provider should be exposed as its own dedicated tool. So the web_search Tencent Cloud branch should be removed unless the full legacy config path is intentionally supported.
Thanks for the PR. Please split this into separate PRs:
One PR for the Tencent Cloud Search tool.
One PR for the Alembic migration fixes, with the exact migration failure scenario included.
The migration changes need extra care. In particular, the change to add_participants.py appears to join identities, but that table is created later in the migration chain, so this may break fresh installs.
For the search tool: the direction is fine, but please keep it as a standalone tool. Our search tools are no longer merged into the old web_search engine selector; each provider should be exposed as its own dedicated tool. So the web_search Tencent Cloud branch should be removed unless the full legacy config path is intentionally supported.
Thanks again.
This PR for Tencent Cloud Search tool. I've removed tencentcloud search from web_search.
I encountered alembic update error when upgrading Clawith from 1.8.2 to 1.8.3-beta.2.
When executing docker exec clawith-backend-1 alembic upgrade heads, I faced roughly 4 errors. I fixed each by following the error message until the upgrade succeeded.
I’m still getting familiar with Clawith and my time is tight recently. I’ll submit search tool PR first and handle the other one later.
Thank you for providing such a useful tool !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Search tool using Tencent Cloud Web Search API (WSA) for users in China.
Checklist