feat:completeness: ajout de la colonne date de création et mois de cr…#447
Open
Tchouanga12 wants to merge 20 commits intomainfrom
Open
feat:completeness: ajout de la colonne date de création et mois de cr…#447Tchouanga12 wants to merge 20 commits intomainfrom
Tchouanga12 wants to merge 20 commits intomainfrom
Conversation
jlecordier
reviewed
Apr 30, 2026
Comment on lines
+408
to
410
| "date_de_creation" timestamp(3) NOT NULL, | ||
| "mois_de_creation" integer NOT NULL, | ||
| "annee_de_creation" integer NOT NULL, |
Collaborator
There was a problem hiding this comment.
Ça sert à quoi d'avoir les 3 ? Autant avoir juste date_de_creation non ?
Collaborator
Author
There was a problem hiding this comment.
C'était pour ne pas casser la ou les autres variable sont deja utilisé. Daccord je vais adapter.
Collaborator
|
@Tchouanga12 Mets tes scripts de conversion dans cette PR stp |
….py: replace method by const
* enable tri altitude, class, creation, fermeture deviation * update swagger * use previous commit structure * gère date_de_fermeture si none dans test
… of annee_de_creation
Co-authored-by: Myriam <mrabhi@corp.free.fr>
…on_classe et station_date_creation
…n-creation-date' of https://github.com/dataforgoodfr/14_ValorisationDonneeMeteo into feat/completeness/ajout-de-nouvelle-colonne-dans-station-creation-date "ajout des fichiers de création des csv sattion_classe et station_date_creation"
Collaborator
|
@Tchouanga12 Faut que tu refasses une branche propre, car c’est tout cassé là |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type de PR
Objectif
Ajout de nouvelles colonnes dans la table « station_creation_date ». Ces colonnes aident à la mise en place de dates rétroactives pour le début du classement des classes.
Contexte
Valider si l’ajout de la colonne « date_creation » est idéal.
Changements
Décisions techniques
Le choix de ces colonnes se base sur leur utilité dans le cadre de la mise en place de la rétroactivité, notamment pour la définition de la date de début de classement.
Impacts
Tests
Points d’attention pour la review
Suivi