fix: add VERSION to builtin function completion#1574
Open
devadathanmb wants to merge 3 commits intodbcli:mainfrom
Open
fix: add VERSION to builtin function completion#1574devadathanmb wants to merge 3 commits intodbcli:mainfrom
VERSION to builtin function completion#1574devadathanmb wants to merge 3 commits intodbcli:mainfrom
Conversation
VERSION to builtin function completion
There was a problem hiding this comment.
Pull request overview
Adds the PostgreSQL built-in VERSION function to pgcli’s function completion list so SELECT VERSION(); is suggested during autocompletion (closes #1510).
Changes:
- Add
VERSIONto the built-in functions literals list. - Add smart- and naive-completion test coverage for
VERSIONsuggestions. - Document the fix in the changelog.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/test_smart_completion_public_schema_only.py | Adds a smart-completion regression test ensuring VERSION is suggested for SELECT VE. |
| tests/test_naive_completion.py | Adds a naive-completion regression test ensuring VERSION is suggested for SELECT VE. |
| pgcli/packages/pgliterals/pgliterals.json | Adds VERSION to the built-in functions literal list used by the completer. |
| changelog.rst | Notes the bug fix in the “Upcoming (TBD)” section. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
VERSIONto pgcli's builtin function completion list soSELECT VERSION();is suggested during autocompletion.Closes #1510
Screenshots
Before:
After:
Checklist
changelog.rst.AUTHORSfile (or it's already there).pip install pre-commit && pre-commit install).