Refactor PostgreSQLExecutor to support Windows compatibility for process management

.github/workflows/oldest-postgres.yml

@@ -52,7 +52,7 @@ jobs:
         run: |
           sudo locale-gen de_DE.UTF-8
       - name: install libpq
-        if: ${{ contains(inputs.python-versions, 'pypy') }}
+        if: ${{ contains(matrix.python-version, 'pypy') && runner.os == 'Linux' }}
         run: sudo apt install libpq5
       - name: Install oldest supported versions
         uses: fizyk/actions-reuse/.github/actions/pipenv-run@v4.4.4

.github/workflows/single-postgres-windows.yml

@@ -0,0 +1,78 @@
+name: Run pytest tests on Windows
+
+on:
+  workflow_call:
+    inputs:
+      python-versions:
+        description: 'Supported python versions'
+        default: '["3.10", "3.11", "3.12", "3.13", "3.14"]'
+        required: false
+        type: string
+      postgresql:
+        description: 'PostgreSQL version'
+        required: true
+        type: number
+    secrets:
+      codecov_token:
+        description: 'Codecov token'
+        required: false
+
+jobs:
+  postgres:
+    runs-on: windows-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        python-version: ${{ fromJSON(inputs.python-versions) }}
+    env:
+      OS: windows-latest
+      PYTHON: ${{ matrix.python-version }}
+      POSTGRES: ${{ inputs.postgresql }}
+    steps:
+      - uses: actions/checkout@v6
+      - name: Set up Pipenv on python ${{ matrix.python-version }}
+        uses: fizyk/actions-reuse/.github/actions/pipenv-setup@v4.4.4
+        with:
+          python-version: ${{ matrix.python-version }}
+          allow-prereleases: true
+      - uses: ankane/setup-postgres@v1
+        with:
+          postgres-version: ${{ inputs.postgresql }}
+      - name: Detect PostgreSQL path on Windows
+        shell: pwsh
+        run: |
+          $pgPath = "C:\Program Files\PostgreSQL\${{ inputs.postgresql }}\bin\pg_ctl.exe"
+          if (Test-Path $pgPath) {
+            echo "POSTGRESQL_EXEC=$pgPath" >> $env:GITHUB_ENV
+          } else {
+            $pgPath = (Get-Command pg_ctl -ErrorAction SilentlyContinue).Source
+            if ($pgPath) {
+              echo "POSTGRESQL_EXEC=$pgPath" >> $env:GITHUB_ENV
+            }
+          }
+
+          # Verify that PostgreSQL was found
+          if (-not $pgPath) {
+            Write-Error "Error: pg_ctl not found in expected locations. Checked hardcoded path and system PATH."
+            exit 1
+          }
+      - name: Run test
+        uses: fizyk/actions-reuse/.github/actions/pipenv-run@v4.4.4
+        with:
+          command: pytest -svv -p no:xdist --postgresql-exec="${{ env.POSTGRESQL_EXEC }}" -k "not docker" --cov-report=xml --basetemp="${{ runner.temp }}/pytest-basetemp"
+      - name: Run xdist test
+        uses: fizyk/actions-reuse/.github/actions/pipenv-run@v4.4.4
+        with:
+          command: pytest -n auto --dist loadgroup --max-worker-restart 0 --postgresql-exec="${{ env.POSTGRESQL_EXEC }}" -k "not docker" --cov-report=xml:coverage-xdist.xml --basetemp="${{ runner.temp }}/pytest-basetemp"
+      - uses: actions/upload-artifact@v7
+        if: failure()
+        with:
+          name: postgresql-windows-${{ matrix.python-version }}-${{ inputs.postgresql }}
+          path: ${{ runner.temp }}/pytest-basetemp/**
+      - name: Upload coverage to Codecov
+        uses: codecov/codecov-action@v6.0.0
+        with:
+          token: ${{ secrets.codecov_token }}
+          flags: unittests
+          env_vars: OS,PYTHON
+          fail_ci_if_error: false

.github/workflows/single-postgres.yml

@@ -43,6 +43,25 @@ jobs:
       - uses: ankane/setup-postgres@v1
         with:
           postgres-version: ${{ inputs.postgresql }}
+      - name: Set PostgreSQL path
+        run: |
+          # Try to find pg_ctl dynamically for cross-platform compatibility
+          if command -v pg_ctl >/dev/null 2>&1; then
+            PG_CTL_PATH=$(command -v pg_ctl)
+            echo "POSTGRESQL_EXEC=$PG_CTL_PATH" >> $GITHUB_ENV
+          elif [ -f "/opt/homebrew/opt/postgresql@${{ inputs.postgresql }}/bin/pg_ctl" ]; then
+            # macOS Apple Silicon Homebrew path
+            echo "POSTGRESQL_EXEC=/opt/homebrew/opt/postgresql@${{ inputs.postgresql }}/bin/pg_ctl" >> $GITHUB_ENV
+          elif [ -f "/usr/local/opt/postgresql@${{ inputs.postgresql }}/bin/pg_ctl" ]; then
+            # macOS Intel Homebrew path
+            echo "POSTGRESQL_EXEC=/usr/local/opt/postgresql@${{ inputs.postgresql }}/bin/pg_ctl" >> $GITHUB_ENV
+          elif [ -f "/usr/lib/postgresql/${{ inputs.postgresql }}/bin/pg_ctl" ]; then
+            # Debian/Ubuntu path (fallback)
+            echo "POSTGRESQL_EXEC=/usr/lib/postgresql/${{ inputs.postgresql }}/bin/pg_ctl" >> $GITHUB_ENV
+          else
+            echo "Error: pg_ctl not found in expected locations"
+            exit 1
+          fi
       - name: Check installed locales
         run: |
           locale -a
@@ -51,21 +70,21 @@ jobs:
         run: |
           sudo locale-gen de_DE.UTF-8
       - name: install libpq
-        if: ${{ contains(inputs.python-versions, 'pypy') }}
+        if: ${{ contains(matrix.python-version, 'pypy') && runner.os == 'Linux' }}
         run: sudo apt install libpq5
       - name: Run test
         uses: fizyk/actions-reuse/.github/actions/pipenv-run@v4.4.4
         with:
-          command: pytest -svv -p no:xdist --postgresql-exec="/usr/lib/postgresql/${{ inputs.postgresql }}/bin/pg_ctl" -k "not docker" --cov-report=xml
+          command: pytest -svv -p no:xdist --postgresql-exec="${{ env.POSTGRESQL_EXEC }}" -k "not docker" --cov-report=xml --basetemp="${{ runner.temp }}/pytest-basetemp"
       - name: Run xdist test
         uses: fizyk/actions-reuse/.github/actions/pipenv-run@v4.4.4
         with:
-          command: pytest -n auto --dist loadgroup --max-worker-restart 0 --postgresql-exec="/usr/lib/postgresql/${{ inputs.postgresql }}/bin/pg_ctl" -k "not docker" --cov-report=xml:coverage-xdist.xml
+          command: pytest -n auto --dist loadgroup --max-worker-restart 0 --postgresql-exec="${{ env.POSTGRESQL_EXEC }}" -k "not docker" --cov-report=xml:coverage-xdist.xml --basetemp="${{ runner.temp }}/pytest-basetemp"
       - uses: actions/upload-artifact@v7
         if: failure()
         with:
           name: postgresql-${{ matrix.python-version }}-${{ inputs.postgresql }}
-          path: /tmp/pytest-of-runner/**
+          path: ${{ runner.temp }}/pytest-basetemp/**
       - name: Upload coverage to Codecov
         uses: codecov/codecov-action@v6.0.0
         with:

.github/workflows/tests.yml

@@ -77,6 +77,14 @@ jobs:
       python-versions: '["3.13", "3.14"]'
     secrets:
       codecov_token: ${{ secrets.CODECOV_TOKEN }}
+  windows_postgres_17:
+    needs: [postgresql_17]
+    uses: ./.github/workflows/single-postgres-windows.yml
+    with:
+      postgresql: 17
+      python-versions: '["3.12", "3.13", "3.14"]'
+    secrets:
+      codecov_token: ${{ secrets.CODECOV_TOKEN }}
   docker_postgresql_18:
     needs: [postgresql_18]
     uses: ./.github/workflows/dockerised-postgres.yml

newsfragments/1182.feature.rst

@@ -0,0 +1 @@
+Add Windows support for ``PostgreSQLExecutor``, including platform-specific start/stop handling.