fix: Delete examples/example_query_and_plot.py#133
Merged
Conversation
Delete a duplicate file. example_query_and_plot.py duplicates example_overview_image.py.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR attempts to remove examples/example_query_and_plot.py as a duplicate of example_overview_image.py. However, the files are not exact duplicates - they contain a critical difference in the plotting logic.
Key Issue
- The file being deleted contains the correct implementation where the SPY plot uses
t=bars_spy - The file being kept (
example_overview_image.py) has a bug where the SPY plot incorrectly usest=bars_dia
Comments suppressed due to low confidence (1)
examples/example_query_and_plot.py:1
- This file should not be deleted as it contains the correct implementation. Line 51 in this file correctly uses
t=bars_spyfor plotting SPY data, whereas the same line inexample_overview_image.pyincorrectly usest=bars_dia. The file being kept has a bug where both DIA and SPY plots reference the DIA data table. Instead of deleting this file, consider fixing line 51 inexample_overview_image.pyto match this correct implementation, or keep this file and delete the other one.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete a duplicate file. example_query_and_plot.py duplicates example_overview_image.py.