feat: Apply AG Grid filter model on pivot table row selection#8
Draft
mofojed wants to merge 7 commits intodeephaven-examples:masterfrom
Draft
feat: Apply AG Grid filter model on pivot table row selection#8mofojed wants to merge 7 commits intodeephaven-examples:masterfrom
mofojed wants to merge 7 commits intodeephaven-examples:masterfrom
Conversation
- Now just need to get it to actually use the selection, extract the keys, and apply them on a filter of a copy of the pivot table
…right - Need the `.copy()` function on PivotTable, but otherwise it works well - Need to clarify if this is the format desired, or if we'd rather just a flat table with the leaf nodes
- Updated handleSelectionChanged to build an AG Grid FilterModel instead of Deephaven filters - Uses text filter with equals type for single values, OR conditions for multiple values - DeephavenViewportDatasource listens for filterChanged event and applies the filter to the Deephaven table server-side - Added Playwright test to verify filtering works correctly - Updated Node.js version to v22.13.1 LTS - Added Playwright as dev dependency for e2e testing - Added playwright-report and test-results to .gitignore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getSourceTable()functions.