Skip to content

feat: DH-19683: Multi-select combobox component#2671

Draft
mofojed wants to merge 10 commits intodeephaven:mainfrom
mofojed:DH-19683-multi-select-component-in-deephaven-ui
Draft

feat: DH-19683: Multi-select combobox component#2671
mofojed wants to merge 10 commits intodeephaven:mainfrom
mofojed:DH-19683-multi-select-component-in-deephaven-ui

Conversation

@mofojed
Copy link
Copy Markdown
Member

@mofojed mofojed commented May 6, 2026

  • WIP, picking up Germain's changes

@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

❌ Patch coverage is 1.46819% with 604 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.35%. Comparing base (d76c08b) to head (625fce6).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...omponents/src/spectrum/multiSelect/MultiSelect.tsx 1.35% 146 Missing ⚠️
...src/spectrum/multiSelect/useMultiSelectKeyboard.ts 0.00% 120 Missing ⚠️
...mponents/src/spectrum/utils/useMultiPickerProps.ts 0.00% 101 Missing ⚠️
...ents/src/spectrum/multiSelect/multiSelectUtils.tsx 0.00% 76 Missing ⚠️
...ts/src/spectrum/multiSelect/useMultiSelectState.ts 0.00% 37 Missing ⚠️
...ectrum/multiSelect/useMultiSelectLoadingSpinner.ts 3.44% 28 Missing ⚠️
...ectrum/multiSelect/useMultiSelectScrollListener.ts 0.00% 24 Missing ⚠️
...ages/jsapi-components/src/spectrum/MultiSelect.tsx 0.00% 21 Missing ⚠️
...s/src/spectrum/multiSelect/useMultiSelectFilter.ts 0.00% 20 Missing ⚠️
...trum/multiSelect/useMultiSelectNormalizedProps.tsx 0.00% 17 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2671      +/-   ##
==========================================
- Coverage   49.76%   49.35%   -0.42%     
==========================================
  Files         774      787      +13     
  Lines       43945    44557     +612     
  Branches    11330    11334       +4     
==========================================
+ Hits        21871    21990     +119     
- Misses      22027    22548     +521     
+ Partials       47       19      -28     
Flag Coverage Δ
unit 49.35% <1.46%> (-0.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants