Skip to content

fix: DH-21843: Fix unexpected code studio unmount#2672

Merged
dgodinez-dh merged 9 commits intodeephaven:mainfrom
dgodinez-dh:dag_DashbaordLayoutBug4
May 6, 2026
Merged

fix: DH-21843: Fix unexpected code studio unmount#2672
dgodinez-dh merged 9 commits intodeephaven:mainfrom
dgodinez-dh:dag_DashbaordLayoutBug4

Conversation

@dgodinez-dh
Copy link
Copy Markdown
Contributor

  • added unit test that mimics the race condition of the bug
  • added unit test for expected behavior when a layout should change
  • change DashboardLayout lastConfig to a ref

@dgodinez-dh dgodinez-dh requested a review from mofojed May 6, 2026 16:43
@dgodinez-dh dgodinez-dh changed the title fix: DH-21843: Fix unexpected dashboard unmount fix: DH-21843: Fix unexpected code studio unmount May 6, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.77%. Comparing base (53e35dd) to head (2098a8c).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2672      +/-   ##
==========================================
- Coverage   49.78%   49.77%   -0.02%     
==========================================
  Files         774      774              
  Lines       43917    43946      +29     
  Branches    11129    11330     +201     
==========================================
+ Hits        21866    21873       +7     
- Misses      22033    22054      +21     
- Partials       18       19       +1     
Flag Coverage Δ
unit 49.77% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@dgodinez-dh dgodinez-dh merged commit ada1e36 into deephaven:main May 6, 2026
17 of 19 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators May 6, 2026
@dgodinez-dh dgodinez-dh deleted the dag_DashbaordLayoutBug4 branch May 6, 2026 18:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants