feat: implement KVM enable and disable flow using ServiceEnabled by amarnath-ac · Pull Request #964 · device-management-toolkit/console

amarnath-ac · 2026-05-11T08:54:40Z

Map ServiceEnabled updates to KVM enable/disable operations with corresponding controller and repository changes

codecov · 2026-05-11T08:59:35Z

Codecov Report

❌ Patch coverage is 68.00000% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 41.49%. Comparing base (921de61) to head (b601c1c).

Files with missing lines	Patch %	Lines
redfish/internal/mocks/mock_repo.go	0.00%	8 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           redfish     #964      +/-   ##
===========================================
+ Coverage    41.22%   41.49%   +0.26%     
===========================================
  Files          152      152              
  Lines        14345    14370      +25     
===========================================
+ Hits          5914     5963      +49     
+ Misses        7858     7834      -24     
  Partials       573      573

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sudhir-intc

How is the KVM service status provided across ISM and AMT devices ?
I tested using following API's on AMT and ISM systems:

# Set environment variables
export CONSOLE_HOST=""
export CONSOLE_USER="admin"
export CONSOLE_PASS=""
export SYSTEM_ID=""

# Enable KVM
curl -sk -X PATCH \
  "${CONSOLE_HOST}/redfish/v1/Systems/${SYSTEM_ID}" \
  -u "${CONSOLE_USER}:${CONSOLE_PASS}" \
  -H 'Content-Type: application/json' \
  -d '{"GraphicalConsole": {"ServiceEnabled": true}}'

# Disable KVM
curl -sk -X PATCH \
  "${CONSOLE_HOST}/redfish/v1/Systems/${SYSTEM_ID}" \
  -u "${CONSOLE_USER}:${CONSOLE_PASS}" \
  -H 'Content-Type: application/json' \
  -d '{"GraphicalConsole": {"ServiceEnabled": false}}'

# Verify current state
curl -sk \
  "${CONSOLE_HOST}/redfish/v1/Systems/${SYSTEM_ID}" \
  -u "${CONSOLE_USER}:${CONSOLE_PASS}" | jq .GraphicalConsole

Here's my observations:

On AMT Systems

Initially ServiceEnabled is set to True and KVMStatus is set to Enabled.
PATCH request of ServiceEnabled to true updates KVMStatus to Enabled and ServiceEnabled to true
PATCH request of ServiceEnabled to false updates KVMStatus to Disabled and ServiceEnabled to false

On ISM Systems

Initially ServiceEnabled is set to False and KVMStatus is set to Disabled.
PATCH request for ServiceEnabled succeeds - Should it not fail ?
Post PATCH request when queried, ServiceEnabled is set to false and KVMStatus as Disabled.

amarnath-ac · 2026-05-18T05:10:32Z

How is the KVM service status provided across ISM and AMT devices ? I tested using following API's on AMT and ISM systems:
# Set environment variables
export CONSOLE_HOST=""
export CONSOLE_USER="admin"
export CONSOLE_PASS=""
export SYSTEM_ID=""

# Enable KVM
curl -sk -X PATCH \
  "${CONSOLE_HOST}/redfish/v1/Systems/${SYSTEM_ID}" \
  -u "${CONSOLE_USER}:${CONSOLE_PASS}" \
  -H 'Content-Type: application/json' \
  -d '{"GraphicalConsole": {"ServiceEnabled": true}}'

# Disable KVM
curl -sk -X PATCH \
  "${CONSOLE_HOST}/redfish/v1/Systems/${SYSTEM_ID}" \
  -u "${CONSOLE_USER}:${CONSOLE_PASS}" \
  -H 'Content-Type: application/json' \
  -d '{"GraphicalConsole": {"ServiceEnabled": false}}'

# Verify current state
curl -sk \
  "${CONSOLE_HOST}/redfish/v1/Systems/${SYSTEM_ID}" \
  -u "${CONSOLE_USER}:${CONSOLE_PASS}" | jq .GraphicalConsole
Here's my observations:

On AMT Systems

Initially ServiceEnabled is set to True and KVMStatus is set to Enabled.

PATCH request of ServiceEnabled to true updates KVMStatus to Enabled and ServiceEnabled to true

PATCH request of ServiceEnabled to false updates KVMStatus to Disabled and ServiceEnabled to false

On ISM Systems

Initially ServiceEnabled is set to False and KVMStatus is set to Disabled.

PATCH request for ServiceEnabled succeeds - Should it not fail ?

Post PATCH request when queried, ServiceEnabled is set to false and KVMStatus as Disabled.

We use usecase.SetFeatures to enable/disable KVM. In ISM case, In REST apis, current behavior is that a KVM enable request does not return an explicit unsupported error. If the backend returns DestinationUnreachable, we currently handle it internally and return a normal success response, with KVM state reflected as disabled in the response fields.
We can change this behavior to return a clear unsupported response from the core DMT API. I will create a ticket for this to make change in code DMT.

amarnath-ac · 2026-05-18T16:44:11Z

How is the KVM service status provided across ISM and AMT devices ? I tested using following API's on AMT and ISM systems:
# Set environment variables
export CONSOLE_HOST=""
export CONSOLE_USER="admin"
export CONSOLE_PASS=""
export SYSTEM_ID=""

# Enable KVM
curl -sk -X PATCH \
  "${CONSOLE_HOST}/redfish/v1/Systems/${SYSTEM_ID}" \
  -u "${CONSOLE_USER}:${CONSOLE_PASS}" \
  -H 'Content-Type: application/json' \
  -d '{"GraphicalConsole": {"ServiceEnabled": true}}'

# Disable KVM
curl -sk -X PATCH \
  "${CONSOLE_HOST}/redfish/v1/Systems/${SYSTEM_ID}" \
  -u "${CONSOLE_USER}:${CONSOLE_PASS}" \
  -H 'Content-Type: application/json' \
  -d '{"GraphicalConsole": {"ServiceEnabled": false}}'

# Verify current state
curl -sk \
  "${CONSOLE_HOST}/redfish/v1/Systems/${SYSTEM_ID}" \
  -u "${CONSOLE_USER}:${CONSOLE_PASS}" | jq .GraphicalConsole
Here's my observations:

On AMT Systems

Initially ServiceEnabled is set to True and KVMStatus is set to Enabled.

PATCH request of ServiceEnabled to true updates KVMStatus to Enabled and ServiceEnabled to true

PATCH request of ServiceEnabled to false updates KVMStatus to Disabled and ServiceEnabled to false

On ISM Systems

Initially ServiceEnabled is set to False and KVMStatus is set to Disabled.

PATCH request for ServiceEnabled succeeds - Should it not fail ?

Post PATCH request when queried, ServiceEnabled is set to false and KVMStatus as Disabled.
We use usecase.SetFeatures to enable/disable KVM. In ISM case, In REST apis, current behavior is that a KVM enable request does not return an explicit unsupported error. If the backend returns DestinationUnreachable, we currently handle it internally and return a normal success response, with KVM state reflected as disabled in the response fields. We can change this behavior to return a clear unsupported response from the core DMT API. I will create a ticket for this to make change in code DMT.

I have tested above behavior with ISM device using REST apis, the mentioned statement is true. I dont see any error logs or failure on console and the enable KVM api return success but in response KVM status will be false.
Also, in web console enable KVM option(button/check box) is disabled, if cursor is placed on enable KVM, "KVM not supported" message is displayed.
We can go ahead with 2 options:

Current PR implementation follows the existing REST apis behavior, we can go ahead with this PR implementation.
Else, for KVM enable request, we can change the set feature API in core DMT to error out in ISM case.

@sudhir-intc, My preference is Option 1, Suggest here.

sudhir-intc · 2026-05-19T04:27:08Z

How is the KVM service status provided across ISM and AMT devices ? I tested using following API's on AMT and ISM systems:
# Set environment variables
export CONSOLE_HOST=""
export CONSOLE_USER="admin"
export CONSOLE_PASS=""
export SYSTEM_ID=""

# Enable KVM
curl -sk -X PATCH \
  "${CONSOLE_HOST}/redfish/v1/Systems/${SYSTEM_ID}" \
  -u "${CONSOLE_USER}:${CONSOLE_PASS}" \
  -H 'Content-Type: application/json' \
  -d '{"GraphicalConsole": {"ServiceEnabled": true}}'

# Disable KVM
curl -sk -X PATCH \
  "${CONSOLE_HOST}/redfish/v1/Systems/${SYSTEM_ID}" \
  -u "${CONSOLE_USER}:${CONSOLE_PASS}" \
  -H 'Content-Type: application/json' \
  -d '{"GraphicalConsole": {"ServiceEnabled": false}}'

# Verify current state
curl -sk \
  "${CONSOLE_HOST}/redfish/v1/Systems/${SYSTEM_ID}" \
  -u "${CONSOLE_USER}:${CONSOLE_PASS}" | jq .GraphicalConsole
Here's my observations:

On AMT Systems

Initially ServiceEnabled is set to True and KVMStatus is set to Enabled.

PATCH request of ServiceEnabled to true updates KVMStatus to Enabled and ServiceEnabled to true

PATCH request of ServiceEnabled to false updates KVMStatus to Disabled and ServiceEnabled to false

On ISM Systems

Initially ServiceEnabled is set to False and KVMStatus is set to Disabled.

PATCH request for ServiceEnabled succeeds - Should it not fail ?

Post PATCH request when queried, ServiceEnabled is set to false and KVMStatus as Disabled.
We use usecase.SetFeatures to enable/disable KVM. In ISM case, In REST apis, current behavior is that a KVM enable request does not return an explicit unsupported error. If the backend returns DestinationUnreachable, we currently handle it internally and return a normal success response, with KVM state reflected as disabled in the response fields. We can change this behavior to return a clear unsupported response from the core DMT API. I will create a ticket for this to make change in code DMT.
I have tested above behavior with ISM device using REST apis, the mentioned statement is true. I dont see any error logs or failure on console and the enable KVM api return success but in response KVM status will be false. Also, in web console enable KVM option(button/check box) is disabled, if cursor is placed on enable KVM, "KVM not supported" message is displayed. We can go ahead with 2 options:

Current PR implementation follows the existing REST apis behavior, we can go ahead with this PR implementation.

Else, for KVM enable request, we can change the set feature API in core DMT to error out in ISM case.

@sudhir-intc, My preference is Option 1, Suggest here.

@amarnath-ac : Could you please create an issue for the Option-2 on DMT so that it can be fixed in the main DMT code. Please past the issue here. Once the issue is capture we could proceed with the merge of this PR

amarnath-ac · 2026-05-19T06:01:02Z

How is the KVM service status provided across ISM and AMT devices ? I tested using following API's on AMT and ISM systems:
# Set environment variables
export CONSOLE_HOST=""
export CONSOLE_USER="admin"
export CONSOLE_PASS=""
export SYSTEM_ID=""

# Enable KVM
curl -sk -X PATCH \
  "${CONSOLE_HOST}/redfish/v1/Systems/${SYSTEM_ID}" \
  -u "${CONSOLE_USER}:${CONSOLE_PASS}" \
  -H 'Content-Type: application/json' \
  -d '{"GraphicalConsole": {"ServiceEnabled": true}}'

# Disable KVM
curl -sk -X PATCH \
  "${CONSOLE_HOST}/redfish/v1/Systems/${SYSTEM_ID}" \
  -u "${CONSOLE_USER}:${CONSOLE_PASS}" \
  -H 'Content-Type: application/json' \
  -d '{"GraphicalConsole": {"ServiceEnabled": false}}'

# Verify current state
curl -sk \
  "${CONSOLE_HOST}/redfish/v1/Systems/${SYSTEM_ID}" \
  -u "${CONSOLE_USER}:${CONSOLE_PASS}" | jq .GraphicalConsole
Here's my observations:

On AMT Systems

Initially ServiceEnabled is set to True and KVMStatus is set to Enabled.

PATCH request of ServiceEnabled to true updates KVMStatus to Enabled and ServiceEnabled to true

PATCH request of ServiceEnabled to false updates KVMStatus to Disabled and ServiceEnabled to false

On ISM Systems

Initially ServiceEnabled is set to False and KVMStatus is set to Disabled.

PATCH request for ServiceEnabled succeeds - Should it not fail ?

Post PATCH request when queried, ServiceEnabled is set to false and KVMStatus as Disabled.
We use usecase.SetFeatures to enable/disable KVM. In ISM case, In REST apis, current behavior is that a KVM enable request does not return an explicit unsupported error. If the backend returns DestinationUnreachable, we currently handle it internally and return a normal success response, with KVM state reflected as disabled in the response fields. We can change this behavior to return a clear unsupported response from the core DMT API. I will create a ticket for this to make change in code DMT.
I have tested above behavior with ISM device using REST apis, the mentioned statement is true. I dont see any error logs or failure on console and the enable KVM api return success but in response KVM status will be false. Also, in web console enable KVM option(button/check box) is disabled, if cursor is placed on enable KVM, "KVM not supported" message is displayed. We can go ahead with 2 options:

Current PR implementation follows the existing REST apis behavior, we can go ahead with this PR implementation.

Else, for KVM enable request, we can change the set feature API in core DMT to error out in ISM case.

@sudhir-intc, My preference is Option 1, Suggest here.
@amarnath-ac : Could you please create an issue for the Option-2 on DMT so that it can be fixed in the main DMT code. Please past the issue here. Once the issue is capture we could proceed with the merge of this PR

Github issue created: #988.
If no other comments, please approve will go ahead to merge after rebasing.

sudhir-intc

LGTM - Proceed with the merge after resolving the conflicts

Map ServiceEnabled updates to KVM enable/disable operations with corresponding controller and repository changes Signed-off-by: C, Amarnath <amarnath.c@intel.com>

amarnath-ac force-pushed the kvm_capabilities branch 5 times, most recently from e712ba7 to d1b1704 Compare May 14, 2026 11:41

amarnath-ac force-pushed the kvm_enable_disable branch from 9c1e9b3 to cf7dd29 Compare May 15, 2026 07:39

amarnath-ac marked this pull request as ready for review May 15, 2026 08:35

amarnath-ac requested review from DevipriyaS17 and sudhir-intc May 15, 2026 08:35

amarnath-ac force-pushed the kvm_enable_disable branch from cf7dd29 to fc4b1a3 Compare May 15, 2026 08:42

Base automatically changed from kvm_capabilities to redfish May 16, 2026 09:15

sudhir-intc reviewed May 16, 2026

View reviewed changes

Comment thread redfish/internal/usecase/wsman_repo.go

sudhir-intc reviewed May 16, 2026

View reviewed changes

amarnath-ac force-pushed the kvm_enable_disable branch from fc4b1a3 to 71b3ea8 Compare May 18, 2026 05:10

sudhir-intc approved these changes May 19, 2026

View reviewed changes

feat: implement KVM enable and disable flow using ServiceEnabled (#830)

b601c1c

Map ServiceEnabled updates to KVM enable/disable operations with corresponding controller and repository changes Signed-off-by: C, Amarnath <amarnath.c@intel.com>

amarnath-ac force-pushed the kvm_enable_disable branch from 71b3ea8 to b601c1c Compare May 19, 2026 06:46

amarnath-ac merged commit 5717a6d into redfish May 19, 2026
21 checks passed

amarnath-ac deleted the kvm_enable_disable branch May 19, 2026 06:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: implement KVM enable and disable flow using ServiceEnabled#964

feat: implement KVM enable and disable flow using ServiceEnabled#964
amarnath-ac merged 1 commit into
redfishfrom
kvm_enable_disable

amarnath-ac commented May 11, 2026

Uh oh!

codecov Bot commented May 11, 2026 •

edited

Loading

Uh oh!

Uh oh!

sudhir-intc left a comment •

edited

Loading

Uh oh!

amarnath-ac commented May 18, 2026

Uh oh!

amarnath-ac commented May 18, 2026

Uh oh!

sudhir-intc commented May 19, 2026

Uh oh!

amarnath-ac commented May 19, 2026

Uh oh!

sudhir-intc left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

amarnath-ac commented May 11, 2026

Uh oh!

codecov Bot commented May 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

sudhir-intc left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

amarnath-ac commented May 18, 2026

Uh oh!

amarnath-ac commented May 18, 2026

Uh oh!

sudhir-intc commented May 19, 2026

Uh oh!

amarnath-ac commented May 19, 2026

Uh oh!

sudhir-intc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov Bot commented May 11, 2026 •

edited

Loading

sudhir-intc left a comment •

edited

Loading