fix: correct inverted GIN_MODE condition in handleDebugMode#979
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #979 +/- ##
=======================================
Coverage 40.80% 40.81%
=======================================
Files 134 134
Lines 12309 12311 +2
=======================================
+ Hits 5023 5025 +2
Misses 6763 6763
Partials 523 523 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* Extract shouldAutoLaunchBrowser() — browser now launches only when GIN_MODE=debug Related to device-management-toolkit/deployment#573
sinchubhat
force-pushed
the
issue573-main-changes
branch
from
cdb1fef to
7771478
Compare
sudhir-intc
approved these changes
May 18, 2026
|
🎉 This PR is included in version 1.26.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to device-management-toolkit/deployment#573
Output: