Skip to content

feat: implement Serialconsole endpoint support#984

Open
DevipriyaS17 wants to merge 2 commits into
redfishfrom
sol_imp
Open

feat: implement Serialconsole endpoint support#984
DevipriyaS17 wants to merge 2 commits into
redfishfrom
sol_imp

Conversation

@DevipriyaS17
Copy link
Copy Markdown
Contributor

Add SerialConsole data model and response mapping with SOL support metadata and targeted tests
SerialConsole
{
"MaxConcurrentSessions": 1,
"Oem": {
"Intel": {
"AMT": {
"ControlMode": "ACM",
"SOLStatus": "Disabled",
"UserConsentStatus": "NotRequired"
}
}
},
"WebSocket": {
"Interactive": true,
"ServiceEnabled": true
}
}
Note: "ControlMode" and "UserConsentStatus" are hardcoded, will implement in another PR.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

❌ Patch coverage is 93.45794% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 41.59%. Comparing base (921de61) to head (9796038).

Files with missing lines Patch % Lines
redfish/internal/usecase/computer_system.go 89.28% 3 Missing and 3 partials ⚠️
redfish/internal/usecase/wsman_repo.go 98.03% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           redfish     #984      +/-   ##
===========================================
+ Coverage    41.22%   41.59%   +0.37%     
===========================================
  Files          152      152              
  Lines        14345    14448     +103     
===========================================
+ Hits          5914     6010      +96     
- Misses        7858     7862       +4     
- Partials       573      576       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

// SOL route and status constants.
solStatusActive = "Active"
serialConsoleMode = "sol"
redirectionWebSocketURI = "/relay/webrelay.ashx"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I see in the serial console output. What is the expectation/usage of the ConsoleURI

curl -sk   "${CONSOLE_HOST}/redfish/v1/Systems/${SYSTEM_ID}"   -u "${CONSOLE_USER}:${CONSOLE_PASS}" | jq .SerialConsole
{
  "MaxConcurrentSessions": 1,
  "Oem": {
    "Intel": {
      "AMT": {
        "ControlMode": "ACM",
        "SOLStatus": "Enabled",
        "UserConsentStatus": "NotRequired"
      }
    }
  },
  "WebSocket": {
    "ConsoleURI": "/relay/webrelay.ashx?host=78563412-0009-0000-0000-000000000000&mode=sol",
    "Interactive": true,
    "ServiceEnabled": true
  }
}
 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants