Skip to content

compiler: Stream related fixes#2701

Closed
mloubout wants to merge 2 commits intomainfrom
stream-fixes
Closed

compiler: Stream related fixes#2701
mloubout wants to merge 2 commits intomainfrom
stream-fixes

Conversation

@mloubout
Copy link
Copy Markdown
Contributor

@mloubout mloubout commented Aug 6, 2025

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 6, 2025

Codecov Report

❌ Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.33%. Comparing base (0d6197b) to head (8ae4ad6).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
conftest.py 71.42% 2 Missing ⚠️
devito/finite_differences/derivative.py 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (0d6197b) and HEAD (8ae4ad6). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (0d6197b) HEAD (8ae4ad6)
18 16
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2701      +/-   ##
==========================================
- Coverage   92.11%   84.33%   -7.78%     
==========================================
  Files         248      248              
  Lines       49644    49654      +10     
  Branches     4367     4368       +1     
==========================================
- Hits        45729    41877    -3852     
- Misses       3208     7012    +3804     
- Partials      707      765      +58     
Flag Coverage Δ
pytest-gpu-aomp-amdgpuX 71.07% <72.72%> (-0.01%) ⬇️
pytest-gpu-nvc-nvidiaX 72.05% <72.72%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@FabioLuporini FabioLuporini changed the title compiler: stream related fixes compiler: Stream related fixes Aug 7, 2025

# Sanity check
assert dag.size == len(efuncs)
assert dag.size == len(defuncs)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what prompted these changes?

foreign calls should never appear inside efuncs

@mloubout mloubout closed this Aug 15, 2025
@mloubout mloubout deleted the stream-fixes branch August 15, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants