Skip to content

UI: Replace 'Fork me on GitHub' ribbon with modern icon (#437) #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Biswas-Samrat wants to merge 3 commits into from
Closed

UI: Replace 'Fork me on GitHub' ribbon with modern icon (#437) #444

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
73150f7
UI: Replace GitHub ribbon with icon and fix overlap on Overview page …
Biswas-Samrat Dec 17, 2025
d1781e5
chore: address review comments - resize icon and remove dead code
Biswas-Samrat Dec 22, 2025
22fe04e
Remove the margin-right and set the hight to 20 px
Biswas-Samrat Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/app/app.component.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,19 @@
color: #ddd;
}

.github-fork-ribbon:before {
background-color: #333;
.github-button img {
margin-right: 20px;
height: 35px;
Copy link
Copy Markdown
Collaborator

@vbakke vbakke Dec 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🙂

The 35px draws a lot of attention. More than a 'Fork me' I think needs.
I propose:

margin-right: 0px;
height: 20px;

What do you think?

Copy link
Copy Markdown
Contributor Author

@Biswas-Samrat Biswas-Samrat Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed the dade code from"src/index.html'

And I think we should add some margin from right to the GitHub, icon, and I resized the icon and 20px height is too small, that's why I gave it 30px height.

Copy link
Copy Markdown
Collaborator

@vbakke vbakke Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing against margin . But it looks unaligned with the rest of the page. Both on the circular heatmap, as well as the Mappings, Settings and Teams.

image

I still thinks is draws too much attention. What about using one of the darker gray from custom-theme.scss.

Copy link
Copy Markdown
Contributor Author

@Biswas-Samrat Biswas-Samrat Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vbakke, I've updated the styles! I reduced the icon height to [20px], removed the extra margin

width: auto;
transition: transform 0.2s;
}

.github-button:hover img {
transform: scale(1.1);
}

:host-context(.dark-theme) .github-button img {
filter: invert(1);
}

@media only screen and (max-width: 750px) {
Expand Down
14 changes: 5 additions & 9 deletions src/app/app.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,11 @@
<div class="tag-subtitle">{{ subtitle }}</div>
</div>
<div class="dummy"></div>
<a
target="_blank"
class="github-fork-ribbon"
href="https://github.com/devsecopsmaturitymodel/DevSecOps-MaturityModel"
data-ribbon="Fork me on GitHub"
title="Fork me on GitHub"
>Fork me on GitHub</a
>
<a target="_blank" class="github-button" href="https://github.com/devsecopsmaturitymodel/DevSecOps-MaturityModel"
data-ribbon="Fork me on GitHub" title="Fork me on GitHub">
<img src="assets/images/github.png" alt="Fork me on GitHub" />
</a>
</div>
<mat-divider></mat-divider>
<router-outlet></router-outlet>
</mat-drawer-container>
</mat-drawer-container>
Binary file added src/assets/images/github.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
40 changes: 19 additions & 21 deletions src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,21 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8" />
<title>DSOMM</title>
<base href="/" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
<link rel="icon" type="image/x-icon" href="favicon.ico" />
<link rel="preconnect" href="https://fonts.gstatic.com" />
<link
href="https://fonts.googleapis.com/css2?family=Roboto:wght@300;400;500&display=swap"
rel="stylesheet" />
<link
href="https://fonts.googleapis.com/icon?family=Material+Icons|Material+Icons+Outlined"
rel="stylesheet" />
<link
rel="stylesheet"
href="https://cdnjs.cloudflare.com/ajax/libs/github-fork-ribbon-css/0.2.3/gh-fork-ribbon.min.css" />
</head>
<body>
<app-root></app-root>
</body>
</html>

<head>
<meta charset="utf-8" />
<title>DSOMM</title>
<base href="/" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
<link rel="icon" type="image/x-icon" href="favicon.ico" />
<link rel="preconnect" href="https://fonts.gstatic.com" />
<link href="https://fonts.googleapis.com/css2?family=Roboto:wght@300;400;500&display=swap" rel="stylesheet" />
<link href="https://fonts.googleapis.com/icon?family=Material+Icons|Material+Icons+Outlined" rel="stylesheet" />
<!-- <link rel="stylesheet"
Copy link
Copy Markdown
Collaborator

@vbakke vbakke Dec 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Please remove the code completely, and I'll approve 🙂👍

href="https://cdnjs.cloudflare.com/ajax/libs/github-fork-ribbon-css/0.2.3/gh-fork-ribbon.min.css" /> -->
</head>

<body>
<app-root></app-root>
</body>

</html>