Skip to content

Commit aae00f7

Browse files
committed
Fix issue with creating internal registry namespace
1 parent 9a5d9c0 commit aae00f7

3 files changed

Lines changed: 20 additions & 0 deletions

File tree

cmd/up.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -203,6 +203,8 @@ func (cmd *UpCmd) ensureNamespace() error {
203203

204204
_, err := cmd.kubectl.CoreV1().Namespaces().Get(releaseNamespace, metav1.GetOptions{})
205205
if err != nil {
206+
log.Infof("Create namespace %s", releaseNamespace)
207+
206208
// Create release namespace
207209
_, err = cmd.kubectl.CoreV1().Namespaces().Create(&k8sv1.Namespace{
208210
ObjectMeta: metav1.ObjectMeta{

pkg/devspace/deploy/helm/rbac.go

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import (
44
"regexp"
55

66
"github.com/covexo/devspace/pkg/devspace/config/v1"
7+
"github.com/covexo/devspace/pkg/util/log"
78
k8sv1 "k8s.io/api/core/v1"
89
k8sv1beta1 "k8s.io/api/rbac/v1beta1"
910
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
@@ -55,6 +56,21 @@ func createTillerRBAC(kubectlClient *kubernetes.Clientset, dsConfig *v1.Config)
5556

5657
// Persist the app namespaces to the config
5758
for _, appNamespace := range appNamespaces {
59+
// Create namespaces if they are not there already
60+
_, err := kubectlClient.CoreV1().Namespaces().Get(*appNamespace, metav1.GetOptions{})
61+
if err != nil {
62+
log.Infof("Create namespace %s", *appNamespace)
63+
64+
_, err = kubectlClient.CoreV1().Namespaces().Create(&k8sv1.Namespace{
65+
ObjectMeta: metav1.ObjectMeta{
66+
Name: *appNamespace,
67+
},
68+
})
69+
if err != nil {
70+
return err
71+
}
72+
}
73+
5874
err = addDeployAccessToTiller(kubectlClient, tillerNamespace, *appNamespace)
5975
if err != nil {
6076
return err

pkg/devspace/deploy/helm/tiller.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,8 @@ func ensureTiller(kubectlClient *kubernetes.Clientset, config *v1.Config, upgrad
3838

3939
_, err := kubectlClient.CoreV1().Namespaces().Get(tillerNamespace, metav1.GetOptions{})
4040
if err != nil {
41+
log.Infof("Create namespace %s", tillerNamespace)
42+
4143
// Create tiller namespace
4244
_, err = kubectlClient.CoreV1().Namespaces().Create(&k8sv1.Namespace{
4345
ObjectMeta: metav1.ObjectMeta{

0 commit comments

Comments
 (0)