Open
Conversation
GreenImp
requested changes
May 13, 2022
Collaborator
GreenImp
left a comment
GreenImp
left a comment
There was a problem hiding this comment.
Looks good 😄
It would be good to add some tests to ensure that an error is thrown if you try to set something that isn't a Dice object. And also some tests to make sure that exporting / importing, and serialising to JSON still works.
| } | ||
|
|
||
| set dice(value) { | ||
| this[diceSymbol] = value; |
Collaborator
There was a problem hiding this comment.
Could you add a check to throw an error if the value isn't a dice object?
GreenImp
force-pushed
the
develop
branch
3 times, most recently
from
4ff7fb9 to
03379d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.