refactor:Remove converted modules#2428
Open
rprospero wants to merge 8 commits into
Open
Conversation
rprospero
force-pushed
the
remove_old_modules
branch
5 times, most recently
from
da77449 to
190d56b
Compare
rprospero
force-pushed
the
remove_old_modules
branch
from
d41faa1 to
1200de5
Compare
rprospero
requested review from
RobBuchananCompPhys and
trisyoungs
and removed request for
trisyoungs
rprospero
force-pushed
the
remove_old_modules
branch
from
1200de5 to
af5ca9b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes some of the modules that we have already converted into nodes. This is only a subset of the modules, as there are some interdependencies between modules where some of them can only be converted in a group.