refactor: Import trajectory nodes#2431
Merged
RobBuchananCompPhys merged 21 commits intoMay 19, 2026
Merged
Conversation
trisyoungs
requested review from
RobBuchananCompPhys and
rprospero
and removed request for
RobBuchananCompPhys
Contributor
RobBuchananCompPhys
left a comment
RobBuchananCompPhys
left a comment
There was a problem hiding this comment.
A couple of suggestions, also would be good to clarify whether we no longer encounter the problem of multiple frame reads by RDF per loop?
…s of DL_POLYs random ordering of parameters.
Co-authored-by: RobBuchanan <106311829+RobBuchananCompPhys@users.noreply.github.com>
Co-authored-by: RobBuchanan <106311829+RobBuchananCompPhys@users.noreply.github.com>
trisyoungs
force-pushed
the
dissolve2/import-trajectory-nodes
branch
from
a4c151a to
8ba884e
Compare
rprospero
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #2427 this PR does the same thing for trajectory import. There's also a bunch of tedious renaming and a final removal of the original import modules (stuff in
io/to follow later).