chore: Remove SpeciesImportFileFormat#2438
Open
trisyoungs wants to merge 3 commits into
Open
Conversation
trisyoungs
added a commit
that referenced
this pull request
May 15, 2026
trisyoungs
added a commit
that referenced
this pull request
May 19, 2026
RobBuchananCompPhys
approved these changes
May 19, 2026
…g a SpeciesNode with a Structure.
trisyoungs
force-pushed
the
dissolve2/remove-speciesimportfileformat
branch
from
a2a497d to
32dd63e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes
SpeciesImportFileFormatas it is now redundant thanks to theImportXYZStructureNode. It was still used in tests related to forcefield assignment, but fixing that requires the ability to create aSpeciesfrom aStructurewhich is the goal of #2436. So, for now those tests are disabled until we are ready to refactor them.Note: This PR fails its CMake formatting check because frankly the reformatted, commented-out unit tests are silly. They will be reinstated soon enough!
Works towards #2436