Skip to content

Add domain push identifier support and account name#324

Merged
ggalmazor merged 3 commits into
mainfrom
add-domain-push-identifier-and-account-name
Apr 14, 2026
Merged

Add domain push identifier support and account name#324
ggalmazor merged 3 commits into
mainfrom
add-domain-push-identifier-and-account-name

Conversation

@ggalmazor
Copy link
Copy Markdown
Contributor

Summary

  • Add new_domain_push_identifier parameter for domain pushes
  • Deprecate new_account_email in favor of new_domain_push_identifier
  • Add name field to Account struct
  • Update fixtures and tests

Closes dnsimple/dnsimple-engineering#425

@ggalmazor
Copy link
Copy Markdown
Contributor Author

Sandbox Integration Test Results

Tested against https://api.sandbox.dnsimple.com using a sandbox user token (dnsimpletest_u_****MIWQ).

/v2/accounts response

Both accounts returned successfully. The name field is correctly deserialized (currently null/nil as the sandbox API does not yet return it — this is expected and will work once the API change is deployed).

Client output

ID: 1324, Email: guillermo.almazor@dnsimple.com, Name: null, Plan: teams-v3-monthly
ID: 2477, Email: guillemo.almazor+corpo@dnsimple.com, Name: null, Plan: corporate-yearly

Unit tests

All unit tests pass ✅

Notes

  • The name field is wired up and ready to deserialize once the API returns it
  • new_domain_push_identifier is a request-only parameter — no sandbox domain push test was run (would require a domain and target account)

@ggalmazor
Copy link
Copy Markdown
Contributor Author

How this was tested

  1. Unit tests — All existing and new unit tests pass. New tests cover:

    • Initiating a domain push with new_domain_push_identifier
    • Asserting the name field on Account
  2. Sandbox integration test — Ran the client against https://api.sandbox.dnsimple.com using a sandbox user token. Verified:

    • /v2/accounts returns successfully and the name field deserializes without error (currently null as the API change is not yet deployed to sandbox)
    • /v2/whoami returns successfully
    • No regressions in existing functionality

@ggalmazor ggalmazor requested a review from a team March 30, 2026 17:59
@ggalmazor ggalmazor self-assigned this Mar 30, 2026
@ggalmazor ggalmazor force-pushed the add-domain-push-identifier-and-account-name branch from a295a01 to ee5653c Compare March 30, 2026 18:01
- Add `new_domain_push_identifier` parameter for domain pushes
- Deprecate `new_account_email` in favor of `new_domain_push_identifier`
- Add `name` field to `Account` struct
- Update fixtures and tests

Closes dnsimple/dnsimple-app#32668
@ggalmazor ggalmazor force-pushed the add-domain-push-identifier-and-account-name branch from ee5653c to 6e2a0bf Compare March 31, 2026 09:38
@ggalmazor
Copy link
Copy Markdown
Contributor Author

Fixtures PR: dnsimple/dnsimple-developer#971

@lokst
Copy link
Copy Markdown
Contributor

lokst commented Apr 9, 2026

@ggalmazor I realized dnsimple/dnsimple-ruby#462 (comment) may need resolving first

Rename new_domain_push_identifier to new_account_identifier to align
with the official API parameter name documented in the developer portal.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@ggalmazor
Copy link
Copy Markdown
Contributor Author

@lokst I updated the branch to address dnsimple/dnsimple-ruby#462 (comment) Can you take another look please?

@lokst
Copy link
Copy Markdown
Contributor

lokst commented Apr 14, 2026

@ggalmazor The changes look good to me 👍

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@ggalmazor ggalmazor merged commit 2a5f3bb into main Apr 14, 2026
9 checks passed
@ggalmazor ggalmazor deleted the add-domain-push-identifier-and-account-name branch April 14, 2026 07:19
ggalmazor added a commit that referenced this pull request Apr 15, 2026
* Add domain push identifier support and account name

- Add `new_domain_push_identifier` parameter for domain pushes
- Deprecate `new_account_email` in favor of `new_domain_push_identifier`
- Add `name` field to `Account` struct
- Update fixtures and tests

Closes dnsimple/dnsimple-app#32668

* Fix domain push parameter name to match API spec

Rename new_domain_push_identifier to new_account_identifier to align
with the official API parameter name documented in the developer portal.

* Add CHANGELOG entry for domain push identifier and account name

---------
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants